[Fix] Multi-root workspaces treat secondary roots as outside the workspace by roomote[bot] · Pull Request #225 · Zoo-Code-Org/Zoo-Code

roomote · 2026-05-21T01:47:13Z

Opened on behalf of Elliott de Launay. View the task or mention @roomote for follow-up asks.

Closes #204

What problem this solves

Fixes an issue where users working in a VS Code multi-root workspace could have tools treat files in secondary roots as outside the workspace. Read, edit, patch, and create flows could resolve relative paths against the first root, and root-specific .rooignore rules were not applied consistently.

Why this change was made

This change makes path resolution choose the workspace root that already contains the target file or its parent directory, then carries that resolved path through ignore and protection checks, file-context tracking, and file-tool operations. It also fixes the Windows absolute-path command case so secondary-root .rooignore rules still apply when commands reference C:\... paths directly, and adds focused unit coverage for the new multi-root resolver and absolute diff-path behavior.

User impact

File tools now behave correctly across multi-root workspaces, including creating new files under the right root and honoring secondary-root .rooignore rules across Unix and Windows command styles.

Related PRs

#228 - follow-up VS Code e2e coverage and harness split

roomote · 2026-05-21T01:47:36Z

No actionable issues found. See task

resolvePathInWorkspace() now resolves brand-new files into the only workspace root that already contains the parent directory, so create flows no longer fall back to the first root in that case.
Secondary-root .rooignore content is now loaded for execute_command and the prompt instructions instead of staying pinned to this.cwd.
~~e2e-mock is still red on the current head: the multi-root repro times out after 60s, so CI still is not proving that the second workspace folder becomes available under GitHub Actions.~~ — moved to sibling PR #228 after splitting the product fix from the VS Code e2e harness work.
validateCommand() no longer skips Windows absolute paths, so validateAccess() still runs for secondary-root C:\\... arguments.
src/core/tools/__tests__/writeToFileTool.spec.ts now uses an explicit platform-aware in-root diff-path expectation, which matches the remaining Windows failure on f455a8e73 instead of feeding the assertion back through mocked path.resolve.
src/core/tools/__tests__/applyPatchTool.execute.spec.ts now matches the actual diff-path behavior on Windows instead of assuming the Linux-only in-root path shape.
src/core/tools/__tests__/listFilesTool.spec.ts, src/core/tools/__tests__/searchFilesTool.spec.ts, and src/core/tools/__tests__/applyDiffTool.spec.ts now directly cover the remaining multi-root path-resolution surfaces that were still missing from the patch.
platform-unit-test (ubuntu-latest) passed on 8a98d562f88b720eb86f84ec58e2d7b11dcb1993 after the bounded wait.
platform-unit-test (windows-latest) passed on 8a98d562f88b720eb86f84ec58e2d7b11dcb1993 after the bounded wait.

roomote · 2026-05-21T02:29:49Z

Pushed d4df00b6e on #225.

What changed:

fixed the remaining Windows-only expectation mismatch in writeToFileTool.spec.ts by making the in-root diff-path expectation explicit per platform instead of routing it back through the mocked path.resolve
kept the patch scoped to the one spec file that still matched the old f455a8e73 failure log

Validation:

pnpm --dir src exec vitest run core/tools/__tests__/writeToFileTool.spec.ts
pnpm --dir src exec vitest run core/tools/__tests__/writeToFileTool.spec.ts core/tools/__tests__/applyPatchTool.execute.spec.ts core/tools/__tests__/listFilesTool.spec.ts core/tools/__tests__/searchFilesTool.spec.ts core/tools/__tests__/applyDiffTool.spec.ts
pnpm --dir apps/web-roo-code test

Visual proof: not applicable for this change because it only updates backend/tooling test coverage.

CI is rerunning now on d4df00b6e. On the previous head f455a8e73, codecov/patch was already green; this push is specifically to clear the remaining platform-unit-test (windows-latest) failure.

codecov · 2026-05-21T02:47:26Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

roomote · 2026-05-27T13:36:49Z

I see some merge conflicts here. Working on them now...

roomote · 2026-05-29T20:11:26Z

I detected merge conflicts but could not start a task to address them.

roomote · 2026-05-29T20:24:11Z

I detected merge conflicts but could not start a task to address them.

roomote · 2026-05-29T21:01:12Z

I detected merge conflicts but could not start a task to address them.

roomote · 2026-05-29T21:06:23Z

I detected merge conflicts but could not start a task to address them.

roomote · 2026-05-29T22:57:52Z

This PR has merge conflicts that need to be resolved.

roomote · 2026-05-30T02:39:45Z

I detected merge conflicts but could not start a task to address them.

roomote · 2026-05-30T02:44:42Z

I detected merge conflicts but could not start a task to address them.

roomote · 2026-05-30T03:56:58Z

I detected merge conflicts but could not start a task to address them.

roomote · 2026-05-30T05:57:50Z

This PR has merge conflicts that need to be resolved.

roomote · 2026-05-30T12:57:51Z

This PR has merge conflicts that need to be resolved.

roomote · 2026-06-03T14:57:47Z

This PR has merge conflicts that need to be resolved.

roomote · 2026-06-03T19:06:41Z

I detected merge conflicts but could not start a task to address them.

roomote · 2026-06-03T21:57:51Z

This PR has merge conflicts that need to be resolved.

roomote · 2026-06-04T04:57:47Z

This PR has merge conflicts that need to be resolved.

roomote · 2026-06-04T11:57:49Z

This PR has merge conflicts that need to be resolved.

roomote · 2026-06-04T12:25:09Z

I detected merge conflicts but could not start a task to address them.

roomote · 2026-06-04T18:57:48Z

This PR has merge conflicts that need to be resolved.

roomote · 2026-06-05T01:16:43Z

I detected merge conflicts but could not start a task to address them.

roomote · 2026-06-05T01:57:48Z

This PR has merge conflicts that need to be resolved.

roomote · 2026-06-05T08:57:49Z

This PR has merge conflicts that need to be resolved.

roomote · 2026-06-05T13:11:40Z

I detected merge conflicts but could not start a task to address them.

roomote · 2026-06-05T14:10:46Z

I detected merge conflicts but could not start a task to address them.

roomote · 2026-06-05T14:48:49Z

I detected merge conflicts but could not start a task to address them.

roomote · 2026-06-05T15:57:49Z

This PR has merge conflicts that need to be resolved.

roomote · 2026-06-05T19:29:38Z

I detected merge conflicts but could not start a task to address them.

roomote · 2026-06-05T21:37:05Z

I detected merge conflicts but could not start a task to address them.

roomote · 2026-06-05T22:57:48Z

This PR has merge conflicts that need to be resolved.

roomote · 2026-06-06T01:33:00Z

I detected merge conflicts but could not start a task to address them.

roomote · 2026-06-06T05:57:48Z

This PR has merge conflicts that need to be resolved.

roomote · 2026-06-06T12:57:48Z

This PR has merge conflicts that need to be resolved.

roomote · 2026-06-06T13:22:42Z

I detected merge conflicts but could not start a task to address them.

roomote · 2026-06-06T13:43:11Z

I detected merge conflicts but could not start a task to address them.

roomote · 2026-06-06T14:10:03Z

I detected merge conflicts but could not start a task to address them.

roomote · 2026-06-06T18:13:56Z

I detected merge conflicts but could not start a task to address them.

roomote · 2026-06-06T19:57:49Z

This PR has merge conflicts that need to be resolved.

roomote · 2026-06-07T00:45:22Z

I detected merge conflicts but could not start a task to address them.

roomote · 2026-06-07T02:57:48Z

This PR has merge conflicts that need to be resolved.

roomote · 2026-06-07T02:59:11Z

I detected merge conflicts but could not start a task to address them.

roomote Bot added the roomote:auto-resolve-conflicts Allow Roomote to auto-resolve merge conflicts for this PR label May 21, 2026

roomote Bot requested review from JamesRobert20, edelauna, hannesrudolph, navedmerchant and taltas as code owners May 21, 2026 01:47

roomote Bot added the roomote:auto-resolve-conflicts Allow Roomote to auto-resolve merge conflicts for this PR label May 21, 2026

roomote Bot commented May 21, 2026

View reviewed changes

Comment thread src/utils/pathUtils.ts Outdated

roomote Bot commented May 21, 2026

View reviewed changes

Comment thread src/core/ignore/RooIgnoreController.ts Outdated

roomote Bot commented May 21, 2026

View reviewed changes

Comment thread apps/vscode-e2e/src/runTest.ts Outdated

roomote Bot commented May 21, 2026

View reviewed changes

Comment thread src/core/ignore/RooIgnoreController.ts Outdated

roomote Bot commented May 21, 2026

View reviewed changes

Comment thread apps/vscode-e2e/src/suite/multi-root-read-file-content.test.ts Outdated

roomote Bot force-pushed the roomote/repro-204-zoocode-e2e branch from 3f96d01 to 5b6b41e Compare May 21, 2026 03:01

roomote Bot mentioned this pull request May 21, 2026

[Chore] Isolate multi-root e2e coverage from the #204 fix #228

Draft

edelauna marked this pull request as draft May 21, 2026 03:07

roomote Bot commented May 21, 2026

View reviewed changes

Comment thread src/core/tools/__tests__/writeToFileTool.spec.ts

deps(knip): configuring knip and removing dead code

5053feb

edelauna force-pushed the roomote/repro-204-zoocode-e2e branch from 8a98d56 to 5053feb Compare June 7, 2026 03:15

Conversation

roomote Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem this solves

Why this change was made

User impact

Related PRs

Uh oh!

roomote Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

roomote Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

roomote Bot commented May 27, 2026

Uh oh!

roomote Bot commented May 29, 2026

Uh oh!

roomote Bot commented May 29, 2026

Uh oh!

roomote Bot commented May 29, 2026

Uh oh!

roomote Bot commented May 29, 2026

Uh oh!

roomote Bot commented May 29, 2026

Uh oh!

roomote Bot commented May 30, 2026

Uh oh!

roomote Bot commented May 30, 2026

Uh oh!

roomote Bot commented May 30, 2026

Uh oh!

roomote Bot commented May 30, 2026

Uh oh!

roomote Bot commented May 30, 2026

Uh oh!

roomote Bot commented Jun 3, 2026

Uh oh!

roomote Bot commented Jun 3, 2026

Uh oh!

roomote Bot commented Jun 3, 2026

Uh oh!

roomote Bot commented Jun 4, 2026

Uh oh!

roomote Bot commented Jun 4, 2026

Uh oh!

roomote Bot commented Jun 4, 2026

Uh oh!

roomote Bot commented Jun 4, 2026

Uh oh!

roomote Bot commented Jun 5, 2026

Uh oh!

roomote Bot commented Jun 5, 2026

Uh oh!

roomote Bot commented Jun 5, 2026

Uh oh!

roomote Bot commented Jun 5, 2026

Uh oh!

roomote Bot commented Jun 5, 2026

Uh oh!

roomote Bot commented Jun 5, 2026

Uh oh!

roomote Bot commented Jun 5, 2026

Uh oh!

roomote Bot commented Jun 5, 2026

Uh oh!

roomote Bot commented Jun 5, 2026

Uh oh!

roomote Bot commented Jun 5, 2026

Uh oh!

roomote Bot commented May 21, 2026 •

edited

Loading

roomote Bot commented May 21, 2026 •

edited

Loading

roomote Bot commented May 21, 2026 •

edited

Loading

codecov Bot commented May 21, 2026 •

edited

Loading