Skip to content

Add gemini-embedding-2 support and update defaults#535

Open
groundmanage2022 wants to merge 1 commit into
Zoo-Code-Org:mainfrom
groundmanage2022:patch-2
Open

Add gemini-embedding-2 support and update defaults#535
groundmanage2022 wants to merge 1 commit into
Zoo-Code-Org:mainfrom
groundmanage2022:patch-2

Conversation

@groundmanage2022

@groundmanage2022 groundmanage2022 commented Jun 8, 2026

Copy link
Copy Markdown

Added support for 'gemini-embedding-2' in various model configurations and updated default model returns for specific providers.

Related GitHub Issue

Closes: #

Description

Test Procedure

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch

Summary by CodeRabbit

Release Notes

  • New Features

    • Added support for Gemini Embedding 2 model across embedding services.
  • Updates

    • Updated default embedding models for improved performance and compatibility across supported providers.

Added support for 'gemini-embedding-2' in various model configurations and updated default model returns for specific providers.
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9ad73111-1ee3-464d-9e16-7af50d60aab9

📥 Commits

Reviewing files that changed from the base of the PR and between c7f1d19 and ace6097.

📒 Files selected for processing (1)
  • src/shared/embeddingModels.ts

📝 Walkthrough

Walkthrough

This PR adds Gemini embedding 2 as a supported embedding model across three providers. The change adds the model profile definitions to gemini, vercel-ai-gateway, and openrouter, then updates default model selections to use gemini-embedding-2 (or the fully qualified google/gemini-embedding-2 for gateway providers).

Changes

Gemini Embedding 2 Support

Layer / File(s) Summary
Gemini Embedding 2 model profiles
src/shared/embeddingModels.ts
gemini provider gains gemini-embedding-2 with dimension and score threshold; vercel-ai-gateway and openrouter Google sub-profiles are extended to include google/gemini-embedding-2.
Default model ID updates
src/shared/embeddingModels.ts
getDefaultModelId() defaults change: gemini returns gemini-embedding-2, and both vercel-ai-gateway and openrouter return google/gemini-embedding-2 instead of prior OpenAI-based defaults.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • taltas
  • navedmerchant
  • hannesrudolph
  • edelauna
  • JamesRobert20

Poem

🐰 A Gemini arrives, shiny and new,
With embeddings flowing the whole PR through,
Dimension and defaults all set in a row,
Three providers now eager to put on a show! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely incomplete. Critical required sections including 'Related GitHub Issue' (no issue number provided), 'Description' (implementation details missing), and 'Test Procedure' are not filled in. The pre-submission checklist is marked complete but lacks supporting details. Complete all required template sections: link a GitHub Issue number, provide implementation details and design rationale, and describe specific testing steps used to validate the changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: adding gemini-embedding-2 support and updating default model returns. It is concise and clearly describes the primary objective of the PR.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant