Skip to content

fix: wrong method name for ExtendedAgentCard endpoint in JsonRpc compat version#931

Merged
guglielmo-san merged 5 commits into1.0-devfrom
guglielmoc/fix_jsonrpc_method_name
Apr 3, 2026
Merged

fix: wrong method name for ExtendedAgentCard endpoint in JsonRpc compat version#931
guglielmo-san merged 5 commits into1.0-devfrom
guglielmoc/fix_jsonrpc_method_name

Conversation

@guglielmo-san
Copy link
Copy Markdown
Member

Description

The correct method name for the ExtendedAgentCard endpoint in JsonRpc v.0.3.0 is agent/getAuthenticatedExtendedCard.
https://a2a-protocol.org/v0.3.0/specification/#710-agentgetauthenticatedextendedcard

@guglielmo-san guglielmo-san changed the base branch from main to 1.0-dev April 3, 2026 09:38
@guglielmo-san guglielmo-san marked this pull request as ready for review April 3, 2026 09:41
@guglielmo-san guglielmo-san requested a review from a team as a code owner April 3, 2026 09:41
@guglielmo-san guglielmo-san enabled auto-merge (squash) April 3, 2026 09:41
auto-merge was automatically disabled April 3, 2026 09:41

Pull request was closed

@guglielmo-san guglielmo-san reopened this Apr 3, 2026
@guglielmo-san guglielmo-san requested a review from ishymko April 3, 2026 09:44
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

🧪 Code Coverage (vs 1.0-dev)

⬇️ Download Full Report

Base PR Delta
src/a2a/compat/v0_3/jsonrpc_adapter.py 47.01% 67.16% 🟢 +20.15%
Total 91.56% 91.91% 🟢 +0.35%

Generated by coverage-comment.yml

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request transitions the A2A SDK to version 1.0, replacing Pydantic-based serialization with Protobuf for messaging and database persistence while ensuring backward compatibility with v0.3. It introduces a new Alembic-based database migration CLI, schema updates for task ownership, and refactored transport implementations for gRPC, REST, and JSON-RPC. Feedback identifies a violation of the project's exception-raising conventions in the event queue implementation.

I am having trouble creating individual review comments. Click here to see my feedback.

src/a2a/server/events/event_queue.py (221)

medium

Exception classes must be raised directly without instantiation, as per the repository rules. Please remove the instantiation and the message to adhere to the rule: 'Raise exception classes directly, without instantiating them'.

References
  1. Raise exception classes directly, without instantiating them (e.g., raise MyError instead of raise MyError()).

@guglielmo-san guglielmo-san enabled auto-merge (squash) April 3, 2026 10:52
@guglielmo-san guglielmo-san merged commit 5d22186 into 1.0-dev Apr 3, 2026
18 checks passed
@guglielmo-san guglielmo-san deleted the guglielmoc/fix_jsonrpc_method_name branch April 3, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants