fix: wrong method name for ExtendedAgentCard endpoint in JsonRpc compat version#931
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/compat/v0_3/jsonrpc_adapter.py | 47.01% | 67.16% | 🟢 +20.15% |
| Total | 91.56% | 91.91% | 🟢 +0.35% |
Generated by coverage-comment.yml
There was a problem hiding this comment.
Code Review
This pull request transitions the A2A SDK to version 1.0, replacing Pydantic-based serialization with Protobuf for messaging and database persistence while ensuring backward compatibility with v0.3. It introduces a new Alembic-based database migration CLI, schema updates for task ownership, and refactored transport implementations for gRPC, REST, and JSON-RPC. Feedback identifies a violation of the project's exception-raising conventions in the event queue implementation.
I am having trouble creating individual review comments. Click here to see my feedback.
src/a2a/server/events/event_queue.py (221)
Exception classes must be raised directly without instantiation, as per the repository rules. Please remove the instantiation and the message to adhere to the rule: 'Raise exception classes directly, without instantiating them'.
References
- Raise exception classes directly, without instantiating them (e.g., raise MyError instead of raise MyError()).
Description
The correct method name for the ExtendedAgentCard endpoint in JsonRpc v.0.3.0 is
agent/getAuthenticatedExtendedCard.https://a2a-protocol.org/v0.3.0/specification/#710-agentgetauthenticatedextendedcard