Skip to content

ci: add a smoke test running outside of the default virtual env#899

Merged
ishymko merged 8 commits into1.0-devfrom
ishymko/integration-package-test
Mar 26, 2026
Merged

ci: add a smoke test running outside of the default virtual env#899
ishymko merged 8 commits into1.0-devfrom
ishymko/integration-package-test

Conversation

@ishymko
Copy link
Copy Markdown
Member

@ishymko ishymko commented Mar 25, 2026

  • Adds a CI workflow that builds and installs a2a-sdk with only base dependencies (no extras or dev group) and verifies all core public API modules import successfully.
  • Prevents regressions like feat: A2A Version Header validation on server side. #865 (fixed in fix: Add packaging to base dependencies #897) where packaging was used in core modules but missing from [project.dependencies]. Since packaging is a transitive dependency of several dev tools, it was always available in CI but not for end-users doing pip install a2a-sdk.

Added a workflow which:

  1. Builds the package wheel.
  2. Creates a clean venv and installs only the wheel.
  3. Runs the import smoke test script against that clean venv.

Tested:

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the project's continuous integration by adding a crucial smoke test. This test specifically targets minimal installations of the a2a-sdk, ensuring that all core public API modules are importable without any optional or development dependencies. This proactive measure aims to prevent issues where users performing a basic pip install might encounter missing dependency errors, thereby improving the reliability and user experience of the SDK.

Highlights

  • New CI Workflow: Introduced a new CI workflow that builds and installs a2a-sdk with only base dependencies and verifies core public API modules import successfully.
  • Dependency Regression Prevention: Addresses and prevents regressions where core modules might rely on transitive dependencies not explicitly listed, ensuring a minimal pip install works as expected.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/minimal-install.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new smoke test script, scripts/test_minimal_install.py, which verifies that all core a2a-sdk modules can be imported successfully with only base dependencies. The script iterates through a predefined list of CORE_MODULES and reports any import failures. Feedback suggests sorting the CORE_MODULES list alphabetically to enhance maintainability and simplify future modifications.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

🧪 Code Coverage (vs 1.0-dev)

⬇️ Download Full Report

No coverage changes.

Generated by coverage-comment.yml

@ishymko ishymko marked this pull request as ready for review March 26, 2026 10:10
@ishymko ishymko requested a review from a team as a code owner March 26, 2026 10:10
@ishymko ishymko requested review from sokoliva March 26, 2026 10:10
@ishymko ishymko merged commit 6fa139e into 1.0-dev Mar 26, 2026
18 checks passed
@ishymko ishymko deleted the ishymko/integration-package-test branch March 26, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants