Skip to content

fix: remove duplicate @expo/metro-config override (unbreak vp install / Release Desktop)#107

Merged
aaditagrawal merged 1 commit into
mainfrom
fix/duplicate-metro-config-override
Jun 19, 2026
Merged

fix: remove duplicate @expo/metro-config override (unbreak vp install / Release Desktop)#107
aaditagrawal merged 1 commit into
mainfrom
fix/duplicate-metro-config-override

Conversation

@aaditagrawal

@aaditagrawal aaditagrawal commented Jun 19, 2026

Copy link
Copy Markdown
Owner

vp install was failing with ERROR duplicated mapping key (66:3), breaking CI and the Release Desktop preflight.

The fork pins @expo/metro-config: 56.0.13 in overrides: (182070b). The pingdotgg#3041 cherry-pick re-added an identical override key, creating a duplicate mapping key that pnpm's strict YAML parser rejects. Removed the duplicate (kept the fork's entry).\n\nVerified: no duplicate mapping keys remain in pnpm-workspace.yaml.

Summary by CodeRabbit

  • Chores
    • Updated workspace configuration to remove previously disabled dependency overrides.

The fork already pins @expo/metro-config to 56.0.13 (182070b). The pingdotgg#3041
cherry-pick re-added an identical override key, producing a duplicate mapping
key that broke "vp install" YAML parsing (CI + Release Desktop preflight).
@aaditagrawal
aaditagrawal merged commit 9d141c1 into main Jun 19, 2026
10 of 11 checks passed
@aaditagrawal
aaditagrawal deleted the fix/duplicate-metro-config-override branch June 19, 2026 16:01
@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Jun 19, 2026
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a2a05a5b-dc4d-4317-ac7a-681ff543b07c

📥 Commits

Reviewing files that changed from the base of the PR and between 88dad59 and 1bc5e7b.

📒 Files selected for processing (1)
  • pnpm-workspace.yaml

📝 Walkthrough

Walkthrough

Removes two entries from the overrides section in pnpm-workspace.yaml that previously set @effect/vitest>@vitest/runner`` and @effect/vitest>vitest to `"-"`, allowing those sub-dependencies to resolve normally again.

Changes

pnpm workspace override cleanup

Layer / File(s) Summary
Remove @effect/vitest sub-dependency overrides
pnpm-workspace.yaml
Deletes the override entries that suppressed @vitest/runner and vitest under @effect/vitest, leaving only the @effect/vitest: "catalog:" override in place.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hopped by and snipped two lines clean,
No more dashes where runners had been,
The vitest sub-deps can now find their way,
Freed from the override cage of the day.
🐇✂️ Less config, more hop!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/duplicate-metro-config-override

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size:XS 0-9 effective changed lines (test files excluded in mixed PRs). label Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant