Route preview automation through live owner streams (#3548) - #127
Conversation
|
Warning Review limit reached
More reviews will be available in 56 minutes. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (69)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
vouch:trusted
9789673 to
d7ec665
Compare
259504c to
cd4e5d8
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cd4e5d8de5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| case "recordingStop": { | ||
| const recordingTabId = readActiveBrowserRecordingTabId(); | ||
| const stopTabId = resolveBrowserRecordingStopTarget(recordingTabId); | ||
| const artifact = stopTabId ? await stopBrowserRecording(stopTabId) : null; |
There was a problem hiding this comment.
Because the automation host is now environment-wide, readActiveBrowserRecordingTabId() can refer to a tab owned by a different thread/provider session than request.threadId. In that case a preview_recording_stop from another agent/thread will stop and return the active recording artifact for the unrelated tab instead of failing for the request's tab, which can corrupt evidence collection and interrupt another workflow; check that the active recording tab belongs to this thread before calling stopBrowserRecording.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cd4e5d8de5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const recordingTabId = readActiveBrowserRecordingTabId(); | ||
| const stopTabId = resolveBrowserRecordingStopTarget(recordingTabId); | ||
| const artifact = stopTabId ? await stopBrowserRecording(stopTabId) : null; |
There was a problem hiding this comment.
When another thread/session has the only active browser recording, this branch ignores request.threadId and stops whatever global recording is active. A preview_recording_stop call from the current thread can therefore stop and return the artifact for a different thread instead of reporting that this thread has no active recording; verify the active recording tab belongs to readThreadPreviewState(threadRef).sessions before calling stopBrowserRecording.
Useful? React with 👍 / 👎.
| if (input.show ?? true) { | ||
| useRightPanelStore.getState().openBrowser(threadRef, activeTabId); |
There was a problem hiding this comment.
When the broker routes preview_open to this environment host for a thread that is not the currently displayed ChatView, this only mutates that thread's right-panel store entry. Nothing activates that thread in the UI, so the default show: true can return with the browser still invisible to the user (and status visible: false); switch to the target thread or otherwise surface the panel when handling background-thread opens.
Useful? React with 👍 / 👎.
Merge activity
|
Co-authored-by: codex <codex@users.noreply.github.com>
cd4e5d8 to
38ef8bd
Compare
2 participants
What Changed
Why
UI Changes
Checklist