Skip to content

feat(mobile): Android beta branding, review-diff UI, and upstream ancestry#154

Merged
aaditagrawal merged 6 commits into
mainfrom
sync/20260715-android
Jul 14, 2026
Merged

feat(mobile): Android beta branding, review-diff UI, and upstream ancestry#154
aaditagrawal merged 6 commits into
mainfrom
sync/20260715-android

Conversation

@aaditagrawal

@aaditagrawal aaditagrawal commented Jul 14, 2026

Copy link
Copy Markdown
Owner

What changed

  • Ports upstream #3967: Android beta branding assets, adaptive/notification icons, and review-diff canvas drawing refactor (ReviewDiffCanvasDrawing).
  • Improves mobile git overview/commit/branch sheet navigation for review flow.
  • Records upstream/main ancestry through 3513fa04f so the tip is zero commits behind upstream (HEAD...upstream/main = 891 0).
  • Preserves fork multi-provider runtime, monitoring, provider management, and orchestration reliability features.

Notes

  • Android review-diff now matches upstream canvas architecture (horizontal pan + extracted drawing). Fork-only Android pull-to-refresh / accessibility virtual nodes from the prior canvas implementation are not reintroduced on top of this refactor (same surface as upstream).

Validation

  • vp check (0 errors)
  • Ancestry merge is content-empty after the three adapted ports (merge records history only)

Stack: 3 of 3; depends on #153.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@aaditagrawal, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 11 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fad8fbee-1c09-4e8c-8e10-7c15373117cf

📥 Commits

Reviewing files that changed from the base of the PR and between 6d62816 and 3ff3021.

⛔ Files ignored due to path filters (7)
  • apps/mobile/assets/android-icon-dev-foreground.png is excluded by !**/*.png
  • apps/mobile/assets/android-icon-foreground.png is excluded by !**/*.png
  • apps/mobile/assets/android-icon-mark.png is excluded by !**/*.png
  • apps/mobile/assets/android-icon-monochrome.png is excluded by !**/*.png
  • apps/mobile/assets/android-notification-icon.png is excluded by !**/*.png
  • apps/mobile/assets/favicon.png is excluded by !**/*.png
  • apps/mobile/assets/icon.png is excluded by !**/*.png
📒 Files selected for processing (16)
  • apps/mobile/app.config.ts
  • apps/mobile/modules/t3-review-diff/android/build.gradle
  • apps/mobile/modules/t3-review-diff/android/src/main/java/expo/modules/t3reviewdiff/ReviewDiffCanvasDrawing.kt
  • apps/mobile/modules/t3-review-diff/android/src/main/java/expo/modules/t3reviewdiff/ReviewDiffCommentDrawing.kt
  • apps/mobile/modules/t3-review-diff/android/src/main/java/expo/modules/t3reviewdiff/T3ReviewDiffModule.kt
  • apps/mobile/modules/t3-review-diff/android/src/main/java/expo/modules/t3reviewdiff/T3ReviewDiffView.kt
  • apps/mobile/src/Stack.tsx
  • apps/mobile/src/components/AndroidScreenHeader.tsx
  • apps/mobile/src/features/cloud/ConnectOnboardingRouteScreen.tsx
  • apps/mobile/src/features/files/ThreadFilesRouteScreen.tsx
  • apps/mobile/src/features/threads/git/GitBranchesSheet.tsx
  • apps/mobile/src/features/threads/git/GitCommitSheet.tsx
  • apps/mobile/src/features/threads/git/GitConfirmSheet.tsx
  • apps/mobile/src/features/threads/git/GitOverviewSheet.tsx
  • apps/mobile/src/features/threads/git/git-overview-navigation.test.ts
  • apps/mobile/src/features/threads/git/git-overview-navigation.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/20260715-android

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

aaditagrawal commented Jul 14, 2026

Copy link
Copy Markdown
Owner Author

@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Jul 14, 2026
@aaditagrawal aaditagrawal changed the title Prepare Android beta branding and review diff UI (#3967) feat(mobile): Android beta branding, review-diff UI, and upstream ancestry Jul 14, 2026
@aaditagrawal

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@github-actions github-actions Bot added the size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). label Jul 14, 2026
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 30edcbe5f8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aaditagrawal commented Jul 14, 2026

Copy link
Copy Markdown
Owner Author

Merge activity

  • Jul 14, 7:50 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 14, 7:54 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 14, 7:54 PM UTC: @aaditagrawal merged this pull request with Graphite.

@aaditagrawal
aaditagrawal changed the base branch from sync/20260715-notifications to graphite-base/154 July 14, 2026 19:51
@aaditagrawal
aaditagrawal changed the base branch from graphite-base/154 to main July 14, 2026 19:52
juliusmarminge and others added 6 commits July 14, 2026 19:53
…oval

Drop the unused swiperefreshlayout dependency and expose a source-mode
Refresh menu action so Android file views stay refreshable without native PTR.
…d comments

Bump rowsDecodeGeneration on content reset so in-flight row decodes cannot
apply stale data, and restore StaticLayout-based multiline comment bodies
with measured row heights in the card-style review diff UI.
Move multiline comment layout/drawing into ReviewDiffCommentDrawing so
DiffCanvasView stays under detekt's size limit after restoring wrapped comments.
@aaditagrawal
aaditagrawal force-pushed the sync/20260715-android branch from 94f5c47 to 3ff3021 Compare July 14, 2026 19:53
@aaditagrawal
aaditagrawal merged commit b198944 into main Jul 14, 2026
12 checks passed
aaditagrawal pushed a commit that referenced this pull request Jul 14, 2026
, pingdotgg#3967)

Content was already adapted via #152#154; keep fork review-diff fixes
and record upstream/main ancestry so the tip is zero commits behind.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants