Skip to content

sync: port upstream desktop changelog tooltip, macOS launcher, icons (#3832, #4102, #4080) - #169

Merged
aaditagrawal merged 3 commits into
mainfrom
sync/20260718-desktop-icons-stack
Jul 18, 2026
Merged

sync: port upstream desktop changelog tooltip, macOS launcher, icons (#3832, #4102, #4080)#169
aaditagrawal merged 3 commits into
mainfrom
sync/20260718-desktop-icons-stack

Conversation

@aaditagrawal

@aaditagrawal aaditagrawal commented Jul 18, 2026

Copy link
Copy Markdown
Owner

What changed

  • #3832 show nightly update changelog tooltip
  • #4102 preserve T3 Code identity in macOS development launcher
  • #4080 refresh app icons across release variants (dev/nightly/prod pipelines)

Preserves fork: fork-only macOS 26 productionMacIconComposer path; multi-provider desktop update IPC contracts.

Validation

  • vp check / vp run typecheck on stack tip
  • Mobile lint: local SwiftLint/SourceKit env failure (unrelated to asset port)
  • CI: pending

Stack: 4 of 5; depends on #168.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@aaditagrawal, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 24 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 89c7e66b-5da1-447f-86af-a5cd08083a07

📥 Commits

Reviewing files that changed from the base of the PR and between 248914d and e3d72a8.

⛔ Files ignored due to path filters (49)
  • apps/mobile/assets/android-icon-dev-foreground.png is excluded by !**/*.png
  • apps/mobile/assets/icon-composer-dev.icon/Assets/Texturelabs_Paper_381XL.jpg is excluded by !**/*.jpg
  • apps/mobile/assets/icon-composer-dev.icon/Assets/gpt-image-1.5-jd70szmrd03p36z4zv48ycsbax81egvr.png is excluded by !**/*.png
  • apps/mobile/assets/icon-composer-prod.icon/Assets/T3.svg is excluded by !**/*.svg
  • apps/mobile/assets/splash-icon-dev.png is excluded by !**/*.png
  • apps/mobile/assets/splash-icon-prod.png is excluded by !**/*.png
  • assets/dev/app-icon.icon/Assets/annotations.svg is excluded by !**/*.svg
  • assets/dev/app-icon.icon/Assets/background.svg is excluded by !**/*.svg
  • assets/dev/app-icon.icon/Assets/text.svg is excluded by !**/*.svg
  • assets/dev/blueprint-icon-composer.icon/Assets/T3.svg is excluded by !**/*.svg
  • assets/dev/blueprint-icon-composer.icon/Assets/Texturelabs_Paper_381XL.jpg is excluded by !**/*.jpg
  • assets/dev/blueprint-icon-composer.icon/Assets/gpt-image-1.5-kn76n9hynne5q3qxy3g91chp2d84t871.png is excluded by !**/*.png
  • assets/dev/blueprint-ios-1024.png is excluded by !**/*.png
  • assets/dev/blueprint-macos-1024.png is excluded by !**/*.png
  • assets/dev/blueprint-universal-1024.png is excluded by !**/*.png
  • assets/dev/blueprint-web-apple-touch-180.png is excluded by !**/*.png
  • assets/dev/blueprint-web-favicon-16x16.png is excluded by !**/*.png
  • assets/dev/blueprint-web-favicon-32x32.png is excluded by !**/*.png
  • assets/dev/blueprint-web-favicon.ico is excluded by !**/*.ico
  • assets/dev/blueprint-windows.ico is excluded by !**/*.ico
  • assets/nightly/app-icon.icon/Assets/background.svg is excluded by !**/*.svg
  • assets/nightly/app-icon.icon/Assets/cloud-lower-left.svg is excluded by !**/*.svg
  • assets/nightly/app-icon.icon/Assets/cloud-upper-right.svg is excluded by !**/*.svg
  • assets/nightly/app-icon.icon/Assets/text.svg is excluded by !**/*.svg
  • assets/nightly/blueprint-ios-1024.png is excluded by !**/*.png
  • assets/nightly/blueprint-macos-1024.png is excluded by !**/*.png
  • assets/nightly/blueprint-universal-1024.png is excluded by !**/*.png
  • assets/nightly/blueprint-web-apple-touch-180.png is excluded by !**/*.png
  • assets/nightly/blueprint-web-favicon-16x16.png is excluded by !**/*.png
  • assets/nightly/blueprint-web-favicon-32x32.png is excluded by !**/*.png
  • assets/nightly/blueprint-web-favicon.ico is excluded by !**/*.ico
  • assets/nightly/blueprint-windows.ico is excluded by !**/*.ico
  • assets/nightly/nightly-ios-1024.png is excluded by !**/*.png
  • assets/nightly/nightly-macos-1024.png is excluded by !**/*.png
  • assets/nightly/nightly-universal-1024.png is excluded by !**/*.png
  • assets/nightly/nightly-web-apple-touch-180.png is excluded by !**/*.png
  • assets/nightly/nightly-web-favicon-16x16.png is excluded by !**/*.png
  • assets/nightly/nightly-web-favicon-32x32.png is excluded by !**/*.png
  • assets/nightly/nightly-web-favicon.ico is excluded by !**/*.ico
  • assets/nightly/nightly-windows.ico is excluded by !**/*.ico
  • assets/prod/app-icon.icon/Assets/text.svg is excluded by !**/*.svg
  • assets/prod/black-ios-1024.png is excluded by !**/*.png
  • assets/prod/black-macos-1024.png is excluded by !**/*.png
  • assets/prod/black-universal-1024.png is excluded by !**/*.png
  • assets/prod/t3-black-web-apple-touch-180.png is excluded by !**/*.png
  • assets/prod/t3-black-web-favicon-16x16.png is excluded by !**/*.png
  • assets/prod/t3-black-web-favicon-32x32.png is excluded by !**/*.png
  • assets/prod/t3-black-web-favicon.ico is excluded by !**/*.ico
  • assets/prod/t3-black-windows.ico is excluded by !**/*.ico
📒 Files selected for processing (27)
  • apps/desktop/scripts/electron-launcher.mjs
  • apps/desktop/scripts/electron-launcher.test.mjs
  • apps/desktop/src/electron/ElectronUpdater.test.ts
  • apps/desktop/src/electron/ElectronUpdater.ts
  • apps/desktop/src/updates/DesktopUpdates.test.ts
  • apps/desktop/src/updates/DesktopUpdates.ts
  • apps/desktop/src/updates/releaseNotes.test.ts
  • apps/desktop/src/updates/releaseNotes.ts
  • apps/desktop/src/updates/updateMachine.test.ts
  • apps/desktop/src/updates/updateMachine.ts
  • apps/mobile/app.config.ts
  • apps/mobile/src/components/BrandMark.tsx
  • apps/web/src/components/desktopUpdate.logic.test.ts
  • apps/web/src/components/sidebar/SidebarUpdatePill.tsx
  • apps/web/src/state/desktopUpdate.test.ts
  • assets/README.md
  • assets/dev/app-icon.icon/icon.json
  • assets/dev/blueprint-icon-composer.icon/icon.json
  • assets/nightly/app-icon.icon/icon.json
  • assets/prod/app-icon.icon/icon.json
  • package.json
  • packages/contracts/src/ipc.ts
  • scripts/export-brand-icons.ts
  • scripts/lib/brand-assets.test.ts
  • scripts/lib/brand-assets.ts
  • scripts/lib/icon-export.test.ts
  • scripts/lib/icon-export.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/20260718-desktop-icons-stack

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). labels Jul 18, 2026
@aaditagrawal aaditagrawal changed the title feat: show nightly update changelog tooltip (#3832) sync: port upstream desktop changelog tooltip, macOS launcher, icons (#3832, #4102, #4080) Jul 18, 2026
@aaditagrawal

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@aaditagrawal
aaditagrawal force-pushed the sync/20260718-shared-docs-stack branch from b5b3e09 to dcd7ce5 Compare July 18, 2026 09:45
@aaditagrawal
aaditagrawal force-pushed the sync/20260718-desktop-icons-stack branch 2 times, most recently from 09e55ea to 5ab443d Compare July 18, 2026 09:47
@aaditagrawal
aaditagrawal force-pushed the sync/20260718-shared-docs-stack branch from dcd7ce5 to 5f7c385 Compare July 18, 2026 09:47

aaditagrawal commented Jul 18, 2026

Copy link
Copy Markdown
Owner Author

Merge activity

  • Jul 18, 10:05 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 18, 10:11 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 18, 10:11 AM UTC: @aaditagrawal merged this pull request with Graphite.

@aaditagrawal
aaditagrawal changed the base branch from sync/20260718-shared-docs-stack to graphite-base/169 July 18, 2026 10:08
@aaditagrawal
aaditagrawal changed the base branch from graphite-base/169 to main July 18, 2026 10:09
HugoVizcainoSantana and others added 3 commits July 18, 2026 10:10
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
(cherry picked from commit 1f27973)
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit 6e9987c)
@aaditagrawal
aaditagrawal force-pushed the sync/20260718-desktop-icons-stack branch from 5ab443d to e3d72a8 Compare July 18, 2026 10:10
@aaditagrawal
aaditagrawal merged commit eefd0c8 into main Jul 18, 2026
12 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e3d72a8762

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

}

const checkedAt = yield* currentIsoTimestamp;
const releaseNotes = normalizeDesktopUpdateReleaseNotes(info.releaseNotes, info.version);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Filter changelog entries to the selected update

When nightly updates enable fullChangelog, GitHub-backed electron-updater can return notes for every release newer than the current app, not just the release selected as info.version. Because this array is normalized and displayed as-is, a nightly user can be shown stable or future release notes that are not included in the update they are about to install (for example when a newer stable release exists in the shared GitHub Releases feed). Please filter the release-note groups to the selected version/channel before broadcasting them.

Useful? React with 👍 / 👎.

@aaditagrawal
aaditagrawal deleted the sync/20260718-desktop-icons-stack branch August 1, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants