sync: reland mobile iOS branding + native stack onto main (#4025, #4037)#178
Conversation
…otgg#4025, pingdotgg#4037) (#176) * fix(mobile): restore iOS home screen branding (pingdotgg#4025) Co-authored-by: Julius Marminge <julius0216@outlook.com> (cherry picked from commit 03e20c8) * fix(mobile): Stabilize native stack option updates (pingdotgg#4037) Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 271454c) --------- Co-authored-by: Alex <me@pixp.cc> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: codex <codex@users.noreply.github.com>
|
Warning Review limit reached
Next review available in: 40 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12b0751c28
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const signature = optionsSignature(stableOptions); | ||
| // Avoid re-entering navigation state when semantically equal options are | ||
| // reapplied every layout (common when callers pass unstable object literals). | ||
| if (lastAppliedOptionsSignatureRef.current === signature) { |
There was a problem hiding this comment.
When a header option is a factory whose output depends on component state, this signature is computed after replacing the factory with a stable wrapper, so closure-only changes all look identical and setOptions is skipped. I checked HomeHeader, which uses unstable_headerToolbarItems to build the iOS search/filter toolbar from hasCustomListOptions, filterMenu, and callbacks; after the user changes sort/filter state, the native toolbar/menu can keep showing the stale icon/checked state because the navigator is never told to re-render those options.
Useful? React with 👍 / 👎.
1 participant
Summary
Relands the already-reviewed mobile sync layer onto
mainafter PR #176 was squash-merged into the stacked base (codex/sync-20260720-desktop-branding-daf2) instead ofmain.This commit is a clean cherry-pick of merge commit
638902f5(#176). Tree parent matches currentmain(fba19aa7/ #174).Upstream ports (unchanged from #176)
#4025)#4037)Test plan
origin/mainCheck/Testgreenmain