Skip to content

sync: port upstream glass redesign and surface polish (#c5ff51ec–#4276)#183

Merged
cursor[bot] merged 17 commits into
mainfrom
codex/sync-20260725-l4-glass-daf2
Jul 25, 2026
Merged

sync: port upstream glass redesign and surface polish (#c5ff51ec–#4276)#183
cursor[bot] merged 17 commits into
mainfrom
codex/sync-20260725-l4-glass-daf2

Conversation

@aaditagrawal

@aaditagrawal aaditagrawal commented Jul 25, 2026

Copy link
Copy Markdown
Owner

Summary

Ports upstream glass redesign and surface polish onto fork main (after #181, #182, #184).

Merge order

#181#182#184 (merged) → #183#185#186#187

Test plan

  • CI Check + Test green
  • Base is main before merge
Open in Web Open in Cursor 

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@cursor[bot], you've reached your PR review limit, so we couldn't start this review.

Next review available in: 26 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: cbece7d2-6725-4029-901f-c3d4904d03e4

📥 Commits

Reviewing files that changed from the base of the PR and between 574a3f7 and c9a2caa.

📒 Files selected for processing (53)
  • apps/desktop/src/settings/DesktopClientSettings.test.ts
  • apps/web/src/components/AppSidebarLayout.tsx
  • apps/web/src/components/BranchToolbar.tsx
  • apps/web/src/components/ChatView.tsx
  • apps/web/src/components/CommandPalette.tsx
  • apps/web/src/components/DiffPanel.tsx
  • apps/web/src/components/GitActionsControl.tsx
  • apps/web/src/components/ProjectScriptsControl.tsx
  • apps/web/src/components/Sidebar.logic.test.ts
  • apps/web/src/components/Sidebar.logic.ts
  • apps/web/src/components/Sidebar.tsx
  • apps/web/src/components/SidebarStageBackdrop.test.tsx
  • apps/web/src/components/SidebarStageBackdrop.tsx
  • apps/web/src/components/SidebarV2.tsx
  • apps/web/src/components/chat/ChangedFilesTree.tsx
  • apps/web/src/components/chat/ChatComposer.tsx
  • apps/web/src/components/chat/ComposerBannerStack.test.tsx
  • apps/web/src/components/chat/ComposerBannerStack.tsx
  • apps/web/src/components/chat/ComposerPrimaryActions.tsx
  • apps/web/src/components/chat/ContextWindowMeter.tsx
  • apps/web/src/components/chat/MessagesTimeline.test.tsx
  • apps/web/src/components/chat/MessagesTimeline.tsx
  • apps/web/src/components/chat/ModelListRow.tsx
  • apps/web/src/components/chat/ModelPickerContent.tsx
  • apps/web/src/components/chat/ModelPickerSidebar.tsx
  • apps/web/src/components/chat/ProviderStatusBanner.test.tsx
  • apps/web/src/components/chat/ProviderStatusBanner.tsx
  • apps/web/src/components/chat/TraitsPicker.tsx
  • apps/web/src/components/settings/AddProviderInstanceDialog.tsx
  • apps/web/src/components/settings/ConnectionsSettings.tsx
  • apps/web/src/components/settings/ProviderInstanceCard.tsx
  • apps/web/src/components/settings/ProviderModelsSection.tsx
  • apps/web/src/components/settings/ProviderSettingsForm.tsx
  • apps/web/src/components/settings/SettingsPanels.tsx
  • apps/web/src/components/settings/SettingsSidebarNav.tsx
  • apps/web/src/components/settings/SourceControlSettings.tsx
  • apps/web/src/components/settings/itemRows.ts
  • apps/web/src/components/settings/settingsLayout.tsx
  • apps/web/src/components/sidebar/SidebarChrome.tsx
  • apps/web/src/components/ui/alert-dialog.tsx
  • apps/web/src/components/ui/button.tsx
  • apps/web/src/components/ui/combobox.tsx
  • apps/web/src/components/ui/command.tsx
  • apps/web/src/components/ui/dialog.tsx
  • apps/web/src/components/ui/menu.tsx
  • apps/web/src/components/ui/popover.tsx
  • apps/web/src/components/ui/select.tsx
  • apps/web/src/hooks/useHandleNewThread.ts
  • apps/web/src/index.css
  • apps/web/src/routes/__root.tsx
  • apps/web/src/routes/settings.tsx
  • packages/contracts/src/settings.test.ts
  • packages/contracts/src/settings.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/sync-20260725-l4-glass-daf2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). labels Jul 25, 2026
@cursor
cursor Bot force-pushed the codex/sync-20260725-l3-sidebar-v2-daf2 branch from eedc8b8 to 273e2cd Compare July 25, 2026 08:52
@cursor
cursor Bot force-pushed the codex/sync-20260725-l4-glass-daf2 branch from ff34606 to 1b6f0cd Compare July 25, 2026 08:52

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ff3460602b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

{/* Chat column */}
<div className="relative flex min-h-0 min-w-0 flex-1 flex-col">
{/* Provider status overlays the timeline without changing its content height. */}
<div className="pointer-events-none absolute inset-x-0 top-0 z-20">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reserve space for the overlaid provider banner

When the active provider reports a warning or error, this absolutely positioned banner is roughly 48px tall, but topFadeEnabled={!hasTimelineTopBanner} makes MessagesTimeline use only its 12–16px compact header. At the top of the conversation, the first timeline row therefore renders underneath the banner and is partially obscured until the user scrolls or dismisses the warning; reserve the banner's height in the timeline or keep it in normal flow.

Useful? React with 👍 / 👎.

/>
<span className="min-w-0 truncate">{project.title}</span>
<span className="min-w-0 truncate text-sm">{project.title}</span>
<button

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Make project removal a keyboard-reachable menu action

In Sidebar V2, this native button is nested inside a MenuRadioItem, while the menu's roving focus targets the enclosing radio item rather than descendants. Keyboard navigation therefore selects or scopes the project when the radio item is activated and provides no menu item that invokes removal, leaving this newly added destructive action pointer-only; expose removal as a separate focusable menu action instead.

Useful? React with 👍 / 👎.

@cursor
cursor Bot force-pushed the codex/sync-20260725-l3-sidebar-v2-daf2 branch from 273e2cd to 2163afd Compare July 25, 2026 09:09
@cursor
cursor Bot force-pushed the codex/sync-20260725-l4-glass-daf2 branch from 1b6f0cd to 67a273a Compare July 25, 2026 09:09
@cursor
cursor Bot force-pushed the codex/sync-20260725-l3-sidebar-v2-daf2 branch from 2163afd to a0b8070 Compare July 25, 2026 09:22
@cursor
cursor Bot force-pushed the codex/sync-20260725-l4-glass-daf2 branch from 67a273a to 6223cb9 Compare July 25, 2026 09:22
@cursor
cursor Bot force-pushed the codex/sync-20260725-l3-sidebar-v2-daf2 branch from a0b8070 to 329c7c0 Compare July 25, 2026 09:26
@cursor
cursor Bot force-pushed the codex/sync-20260725-l4-glass-daf2 branch from 6223cb9 to 6b45ba1 Compare July 25, 2026 09:26
@cursor
cursor Bot force-pushed the codex/sync-20260725-l3-sidebar-v2-daf2 branch from 329c7c0 to 5507495 Compare July 25, 2026 09:36
@cursor
cursor Bot force-pushed the codex/sync-20260725-l4-glass-daf2 branch from 6b45ba1 to 35d7acb Compare July 25, 2026 09:36
@cursor
cursor Bot force-pushed the codex/sync-20260725-l3-sidebar-v2-daf2 branch from 5507495 to 7142329 Compare July 25, 2026 09:42
@cursor
cursor Bot force-pushed the codex/sync-20260725-l4-glass-daf2 branch from 35d7acb to fec2c09 Compare July 25, 2026 09:42
@cursor
cursor Bot force-pushed the codex/sync-20260725-l3-sidebar-v2-daf2 branch from 7142329 to fbfe08c Compare July 25, 2026 09:48
@cursor
cursor Bot force-pushed the codex/sync-20260725-l4-glass-daf2 branch from fec2c09 to cf779fe Compare July 25, 2026 09:48
@cursor
cursor Bot force-pushed the codex/sync-20260725-l3-sidebar-v2-daf2 branch from fbfe08c to ee2f96f Compare July 25, 2026 09:59
@cursor
cursor Bot force-pushed the codex/sync-20260725-l4-glass-daf2 branch from cf779fe to 7506571 Compare July 25, 2026 09:59
@cursor
cursor Bot force-pushed the codex/sync-20260725-l3-sidebar-v2-daf2 branch from ee2f96f to b9a19ee Compare July 25, 2026 10:04
@cursor
cursor Bot force-pushed the codex/sync-20260725-l4-glass-daf2 branch from 7506571 to d9a29ca Compare July 25, 2026 10:04
@cursor
cursor Bot force-pushed the codex/sync-20260725-l3-sidebar-v2-daf2 branch from b9a19ee to be17b97 Compare July 25, 2026 10:11
@cursor
cursor Bot force-pushed the codex/sync-20260725-l4-glass-daf2 branch from d9a29ca to 4a8a97e Compare July 25, 2026 10:11
@cursor
cursor Bot force-pushed the codex/sync-20260725-l3-sidebar-v2-daf2 branch from be17b97 to 7127e2a Compare July 25, 2026 10:16
@cursor
cursor Bot force-pushed the codex/sync-20260725-l4-glass-daf2 branch from 4a8a97e to fd8bdc5 Compare July 25, 2026 10:16
@cursor
cursor Bot force-pushed the codex/sync-20260725-l3-sidebar-v2-daf2 branch from 7127e2a to 5a63f00 Compare July 25, 2026 10:22
@cursor
cursor Bot force-pushed the codex/sync-20260725-l4-glass-daf2 branch 2 times, most recently from 504ae4e to 9a4f596 Compare July 25, 2026 10:31
maria-rcks and others added 16 commits July 25, 2026 10:37
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit 14b6bfd)
(cherry picked from commit d330759)
(cherry picked from commit 39cd15b)

Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
…tgg#4276)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
(cherry picked from commit 16491a8)
@cursor
cursor Bot changed the base branch from codex/sync-20260725-l3-sidebar-v2-daf2 to main July 25, 2026 10:39
@cursor
cursor Bot force-pushed the codex/sync-20260725-l4-glass-daf2 branch from 9a4f596 to 662ccf6 Compare July 25, 2026 10:39
Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
@cursor
cursor Bot merged commit 454fd79 into main Jul 25, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants