sync: port upstream glass redesign and surface polish (#c5ff51ec–#4276)#183
Conversation
|
Warning Review limit reached
Next review available in: 26 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (53)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
eedc8b8 to
273e2cd
Compare
ff34606 to
1b6f0cd
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff3460602b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {/* Chat column */} | ||
| <div className="relative flex min-h-0 min-w-0 flex-1 flex-col"> | ||
| {/* Provider status overlays the timeline without changing its content height. */} | ||
| <div className="pointer-events-none absolute inset-x-0 top-0 z-20"> |
There was a problem hiding this comment.
Reserve space for the overlaid provider banner
When the active provider reports a warning or error, this absolutely positioned banner is roughly 48px tall, but topFadeEnabled={!hasTimelineTopBanner} makes MessagesTimeline use only its 12–16px compact header. At the top of the conversation, the first timeline row therefore renders underneath the banner and is partially obscured until the user scrolls or dismisses the warning; reserve the banner's height in the timeline or keep it in normal flow.
Useful? React with 👍 / 👎.
| /> | ||
| <span className="min-w-0 truncate">{project.title}</span> | ||
| <span className="min-w-0 truncate text-sm">{project.title}</span> | ||
| <button |
There was a problem hiding this comment.
Make project removal a keyboard-reachable menu action
In Sidebar V2, this native button is nested inside a MenuRadioItem, while the menu's roving focus targets the enclosing radio item rather than descendants. Keyboard navigation therefore selects or scopes the project when the radio item is activated and provides no menu item that invokes removal, leaving this newly added destructive action pointer-only; expose removal as a separate focusable menu action instead.
Useful? React with 👍 / 👎.
273e2cd to
2163afd
Compare
1b6f0cd to
67a273a
Compare
2163afd to
a0b8070
Compare
67a273a to
6223cb9
Compare
a0b8070 to
329c7c0
Compare
6223cb9 to
6b45ba1
Compare
329c7c0 to
5507495
Compare
6b45ba1 to
35d7acb
Compare
5507495 to
7142329
Compare
35d7acb to
fec2c09
Compare
7142329 to
fbfe08c
Compare
fec2c09 to
cf779fe
Compare
fbfe08c to
ee2f96f
Compare
cf779fe to
7506571
Compare
ee2f96f to
b9a19ee
Compare
7506571 to
d9a29ca
Compare
b9a19ee to
be17b97
Compare
d9a29ca to
4a8a97e
Compare
be17b97 to
7127e2a
Compare
4a8a97e to
fd8bdc5
Compare
7127e2a to
5a63f00
Compare
504ae4e to
9a4f596
Compare
(cherry picked from commit c5ff51e)
(cherry picked from commit b6a2563)
Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 14b6bfd)
(cherry picked from commit 29b1abc)
(cherry picked from commit 6e5df67)
(cherry picked from commit 10da67b)
(cherry picked from commit 0b1ce58)
(cherry picked from commit 5961d36)
(cherry picked from commit d330759)
(cherry picked from commit 160d97f)
(cherry picked from commit 39cd15b) Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
(cherry picked from commit c38225e)
(cherry picked from commit 936394b)
(cherry picked from commit 9c9916a)
(cherry picked from commit b44ed83)
9a4f596 to
662ccf6
Compare
Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
Summary
Ports upstream glass redesign and surface polish onto fork
main(after #181, #182, #184).Merge order
#181→#182→#184(merged) →#183→#185→#186→#187Test plan
mainbefore merge