fix(ci): fall back to github.token when RELEASE_APP secrets are missing - #212
Conversation
Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
|
Warning Review limit reached
Next review available in: 16 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 889535d143
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| GH_TOKEN: ${{ steps.app_token.outputs.token || github.token }} | ||
| APP_SLUG: ${{ steps.app_token.outputs.app-slug }} |
There was a problem hiding this comment.
Provide a non-App identity on token fallback
When either RELEASE_APP_* secret is missing, the continued mint step produces neither a token nor app-slug; falling back only GH_TOKEN therefore leaves APP_SLUG empty, and the stable-release finalize job invokes gh api "/users/[bot]" before it can update or push version strings. The gh api manual confirms that this argument is used as the API endpoint, so this request fails rather than resolving the github.token actor. Conditionally use the App identity only when app-slug exists and otherwise supply the GitHub Actions bot identity.
Useful? React with 👍 / 👎.
| ref: main | ||
| fetch-depth: 0 | ||
| token: ${{ steps.app_token.outputs.token }} | ||
| token: ${{ steps.app_token.outputs.token || github.token }} |
There was a problem hiding this comment.
Preserve CI for the fallback version-bump push
When the App token is unavailable, this checkout persists github.token, so the later git push origin HEAD:main authenticates with GITHUB_TOKEN. GitHub documents that events created with this token do not start new workflow runs (apart from workflow_dispatch and repository_dispatch), meaning the version-bump commit will not trigger the push-to-main workflows inspected in .github/workflows/ci.yml and .github/workflows/deploy-relay.yml; in particular, the generated package and lockfile changes land without the repository's main-branch CI. Use a credential that can trigger those workflows or explicitly dispatch the required validation after this fallback push. See Triggering a workflow from a workflow.
Useful? React with 👍 / 👎.
Unblocks
v0.0.32publish after the sync.Problem
Release run failed minting the GitHub App token (
appId option is required) becauseRELEASE_APP_ID/RELEASE_APP_PRIVATE_KEYwere empty in the Publish job.Fix
In
releaseandfinalizejobs:continue-on-error: truesteps.app_token.outputs.token || github.tokenRELEASE_APP_*when configured; fall back togithub.token(upstream fix(ci): isolate releases from shared API rate limits pingdotgg/t3code#5394 path) when notAfter merge, retag
v0.0.32onto the fixed workflow and re-run the release.