[WIP] migrate ROOT's cppyy to leverage InterOp for bindings#1
Open
aaronj0 wants to merge 7 commits into
Open
Conversation
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 74d7876. |
aaronj0
force-pushed
the
cppyy-migration
branch
from
74d7876 to
a554b17
Compare
With this patch, we enable clingwrapper to load all of the CppInterOp API required by cppyy using the gInterpreterLib handle used in TROOT This mechanism cannot open libCling unless libCore is loaded.
…med and GetAllCppNames
aaronj0
force-pushed
the
cppyy-migration
branch
from
a554b17 to
17384f1
Compare
aaronj0
added a commit
that referenced
this pull request
Jun 29, 2026
The latest CppInterOp upgrade changes UseExternalInterpreter to also install a CppInteropDiagConsumer onto Cling's DiagnosticsEngine. Rootcling later wraps the current diag client with CheckModuleBuildClient via DiagnosticsEngine::setClient which deletes CppInterOp's previously-owned client. This leads to CheckModuleBuildClient holding a dangling fChild pointer. Without this patch, at cling::Interpreter::ShutDown: #0 0x0000000000000000 #1 CheckModuleBuildClient::EndSourceFile rootcling_impl.cxx:3517 root-project#2 cling::Interpreter::ShutDown Interpreter.cpp:590 root-project#3 cling::Interpreter::~Interpreter Interpreter.cpp:394 crashes. Since rootcling does not use CppInterOp, we can avoid registering the interpreter with CppInterOp if we are running in rootcling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.