Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
* { path: '/sap/bc/adt/atc/runs', methods: ['POST'] }
*/

// eslint-disable-next-line @nx/enforce-module-boundaries
import type { EndpointDefinition } from '@abapify/adt-codegen';

export const enabledEndpoints: EndpointDefinition[] = [
Expand Down
2 changes: 2 additions & 0 deletions packages/adt-playwright/src/adapter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ export function createPlaywrightAdapter(): BrowserAdapter {
if (!page) throw new Error('Page not created');
await page
.goto(url, { timeout: options?.timeout ?? 30000 })
// Navigation errors are intentionally ignored; caller handles auth via event listeners
// eslint-disable-next-line @typescript-eslint/no-empty-function
.catch(() => {});
},

Expand Down
2 changes: 1 addition & 1 deletion packages/adt-plugin-abapgit/eslint.config.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import baseConfig from '../../../eslint.config.js';
import baseConfig from '../../eslint.config.mjs';

export default [...baseConfig];
2 changes: 1 addition & 1 deletion packages/adt-plugin-abapgit/src/lib/handlers/base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export type InferAdkData<T> =
* We use `any[]` for constructor args since we only need the static `kind` property,
* not to actually instantiate the class.
*/

export type AdkObjectClass<T extends AdkObject = AdkObject> = {
new (...args: any[]): T;
readonly kind: AdkKind;
Expand Down
2 changes: 2 additions & 0 deletions packages/adt-puppeteer/src/adapter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ export function createPuppeteerAdapter(): BrowserAdapter {
waitUntil: 'domcontentloaded',
timeout: options?.timeout ?? 30000,
})
// Navigation errors are intentionally ignored; caller handles auth via event listeners
// eslint-disable-next-line @typescript-eslint/no-empty-function
.catch(() => {});
},

Expand Down
1 change: 1 addition & 0 deletions packages/adt-puppeteer/vitest.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@ export default defineConfig({
include: ['tests/**/*.test.ts'],
globals: true,
environment: 'node',
passWithNoTests: true,
},
});
2 changes: 1 addition & 1 deletion packages/adt-tui/src/pages/_routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export interface Route {
export const routes: Route[] = [
{
pattern: '/sap/bc/adt/cts/transportrequests/:slug',
regex: new RegExp('^/sap\/bc\/adt\/cts\/transportrequests\/([^\/]+)$'),
regex: new RegExp('^/sap/bc/adt/cts/transportrequests/([^/]+)$'),
page: Page0,
},
];
Expand Down
2 changes: 1 addition & 1 deletion packages/asjson-parser/eslint.config.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import baseConfig from '../../eslint.config.js';
import baseConfig from '../../eslint.config.mjs';

export default [...baseConfig];
4 changes: 3 additions & 1 deletion packages/browser-auth/src/auth-core.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,9 @@ export async function authenticate(
}
});

// Navigate - events are already set up
// Navigate - events are already set up; navigation errors are expected
// (auth flow handles results through response event listeners, not navigation result)
// eslint-disable-next-line @typescript-eslint/no-empty-function
adapter.goto(targetUrl, { timeout: 30000 }).catch(() => {});
});

Expand Down
6 changes: 6 additions & 0 deletions packages/logger/src/loggers/noop-logger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,17 @@ import type { Logger } from '../types';
* Useful for testing or when logging is not needed
*/
export class NoOpLogger implements Logger {
// eslint-disable-next-line @typescript-eslint/no-empty-function
trace(): void {}
// eslint-disable-next-line @typescript-eslint/no-empty-function
debug(): void {}
// eslint-disable-next-line @typescript-eslint/no-empty-function
info(): void {}
// eslint-disable-next-line @typescript-eslint/no-empty-function
warn(): void {}
// eslint-disable-next-line @typescript-eslint/no-empty-function
error(): void {}
// eslint-disable-next-line @typescript-eslint/no-empty-function
fatal(): void {}
child(): Logger {
return this;
Expand Down
2 changes: 2 additions & 0 deletions packages/speci/src/rest/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export interface RestEndpointOptions<
/**
* HTTP helper object with optional global responses
*/
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
type Http<TGlobalResponses extends ResponseMap = {}> = {
// GET - with shortcut syntax
get: {
Expand Down Expand Up @@ -172,6 +173,7 @@ type Http<TGlobalResponses extends ResponseMap = {}> = {
* // 400, 401, 500 are automatically added
* })
*/
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export function createHttp<TGlobalResponses extends ResponseMap = {}>(
globalResponses?: TGlobalResponses,
): Http<TGlobalResponses> {
Expand Down
4 changes: 3 additions & 1 deletion packages/speci/src/rest/inferrable.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,15 @@ describe('InferSchema with complex types', () => {
? E extends Record<string, unknown>
? { data: string }
: never
: {};
: // eslint-disable-next-line @typescript-eslint/no-empty-object-type
{};

// Simulate SpeciSchema - like adt-schemas does
type SimulatedSpeciSchema<T> = T & Serializable<SimulatedInferXsd<T>>;

it('should infer type from Serializable with complex generic', () => {
// This simulates what adt-schemas does
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
type Schema = SimulatedSpeciSchema<{ root: 'test'; elements: { foo: {} } }>;

// InferSchema should extract the type from _infer
Expand Down
1 change: 1 addition & 0 deletions tools/nx-sync/src/generators/nested-sync/schema.d.ts
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
// eslint-disable-next-line @typescript-eslint/no-empty-object-type, @typescript-eslint/no-empty-interface
export interface NxNestedSyncGeneratorSchema {}