Set default shell to bash in Makefile - #4
Open
GrumpyLittleTed wants to merge 3 commits into
Open
Conversation
Author
|
I have added a new createjsdet function for deterministic functions so that those functions can be used in expression indexes. It would have been nice if createjs had an options argument to add this but I am not familiar with duktape and argument passing so for now I just added it as a separate function as a proof of concept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make fails if default shell not set to bash (says '[' not recognised).
Fix is to add SHELL=/usr/bin to Makefile.
Pull request resubmitted as previous closed request accidentally duktape build :-(