Rewrite docs/Testing.md as a focused testing guide#199
Open
Conversation
Replace the 400-line emoji-heavy doc with a 249-line guide that answers the key question: "I wrote a new command — what tests do I need?" - Define four test layers (unit, E2E, TTY, subprocess) with clear purpose, speed, and "when to use" guidance - Make unit and E2E tests mandatory for every command - Add decision tree and explicit rules for choosing the right layer - Honestly describe test/integration/ as 4 interactive-mode files, not a general-purpose integration tier - Add helpers reference tables (core helpers, mock SDKs, factories, NDJSON, TTY) - Remove decorative HTML, collapsed sections, and misleading integration test description - Move test structure, describe blocks, and running tests out of AGENTS.md into Testing.md with a cross-reference Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThis PR rewrites Changes
Review Notes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The old
docs/Testing.mdwas 400 lines of unfocused guidance — heavy on running commands and debugging env vars, light on what to test and when. It didn't answer the key questions a contributor needs:The "integration" layer was also misleading — it's 4 files all testing interactive mode subprocess behavior, not a general-purpose middle tier.
What changed
test/integration/as 4 interactive-mode files, not a general-purpose tierTest plan
pnpm exec eslint .passes (0 errors)🤖 Generated with Claude Code