Harden ESLint rules for react-web-cli package

[AndyTWF]

Summary

Incrementally enables strict TypeScript and code quality ESLint rules for packages/react-web-cli, closing gaps that allowed dead code, type safety holes, and stale closures to slip through undetected.

• Enable no-unused-vars — removed 30 unused imports, variables, and state declarations
• Enable unicorn rules — prefer-string-slice, prefer-code-point, no-negated-condition (fixes surrogate pair bugs, improves readability)
• Install eslint-plugin-react-hooks — catches stale closures and hook ordering bugs in the 3,600-line main component
• Enable no-console — migrated ~25 console.log calls to gated debugLog() helper
• Enable no-explicit-any — created types.ts with proper discriminated unions (ControlMessage, AblyCliGlobals, WebSocketMessageData) replacing ~24 any annotations
• Upgrade to recommended-type-checked — full type-aware linting with no-unsafe-* family, no-misused-promises, no-floating-promises
• Promote all rules to error — source files enforced strictly, test files exempt for mocking flexibility

Final state: 0 errors, 22 warnings (16 exhaustive-deps + 6 no-disabled-tests — both intentionally left as warnings).

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
cli-web-cli	Ready	Preview, Comment	Apr 1, 2026 1:01pm

[claude-code-ably-assistant]

Walkthrough

This PR incrementally hardens ESLint and TypeScript rules for the packages/react-web-cli package, eliminating dead code, type safety holes, and potential stale closure bugs that were previously undetected. It progresses from enabling no-unused-vars through unicorn rules, eslint-plugin-react-hooks, no-console, no-explicit-any, and finally full recommended-type-checked + strict enforcement — arriving at 0 errors with only 16 exhaustive-deps (suppressed with documented rationale) and 6 no-disabled-tests remaining as warnings.

Changes

Area	Files	Summary
Config	eslint.config.js	Adds react-hooks plugin, upgrades to recommended-type-checked, promotes all new rules to error in source, exempts test files from no-unsafe-* / no-explicit-any
Config	package.json, pnpm-lock.yaml	Adds eslint-plugin-react-hooks dev dependency
Components	packages/react-web-cli/src/AblyCliTerminal.tsx	Removes 30+ dead variables/state, migrates console.log → debugLog(), fixes exhaustive-deps via ref patterns and documented suppressions, converts value imports to type imports
Components	packages/react-web-cli/src/TerminalOverlay.tsx	Replaces charCodeAt() with codePointAt() for correct surrogate pair handling
Services	packages/react-web-cli/src/global-reconnect.ts	Type safety fixes; removes any annotations
Utils	packages/react-web-cli/src/terminal-shared.ts, terminal-box.ts	Removes unused variables; replaces any with unknown
Utils	packages/react-web-cli/src/use-terminal-visibility.ts	Flips negated conditions to positive-first; converts value imports to type imports
New File	packages/react-web-cli/src/types.ts	Introduces ControlMessage discriminated union, AblyCliGlobals interface, TerminalWithConnectingState, and WebSocketMessageData type — replaces ~24 any annotations
Tests	packages/react-web-cli/src/AblyCliTerminal.test.tsx, AblyCliTerminal.resize.test.tsx	Updates assertions to match debugLog() output format (prefix + ABLY_CLI_DEBUG env var)

Review Notes

• Behavioral change — debugLog() gating: ~25 debug console.log calls are now only emitted when ABLY_CLI_DEBUG is set. Any developer relying on those logs without that env var will no longer see them.
• Surrogate pair fix: charCodeAt() → codePointAt() in TerminalOverlay.tsx and AblyCliTerminal.tsx is a real bug fix for emoji/wide characters — reviewers should check the context is correct (no off-by-one from the index difference).
• exhaustive-deps suppressions: 6 eslint-disable-next-line comments suppress the rule for mount-only useEffect blocks (terminal init) and hoisted callback refs. Each has a documented rationale in the commit messages — reviewers should verify the suppression comments in source are similarly clear.
• New types.ts: The ControlMessage discriminated union now removes dead branches that checked for stream/hijack properties — confirm those message types are truly retired upstream.
• No runtime logic changes: All changes are dead-code removal, type annotations, or code style fixes. The only functional change is debugLog() gating and the codePointAt() fix.