Support for encryption of shared preferences#681
Merged
QuintinWillison merged 8 commits intomainfrom Aug 5, 2021
Merged
Conversation
Contributor
martin-morek
commented
Jul 2, 2021
martin-morek
commented
- Fixes 593
- Default SharedPreferences could be replaced with custom Storage implementation, ClientOptions allows to inject custom object. If nothing is injected current behaviour using SharedPreferences is used so no need to do any changes to keep current functionality.
…default SharedPreferences
sacOO7
reviewed
Jul 7, 2021
sacOO7
reviewed
Jul 7, 2021
android/src/main/java/io/ably/lib/push/SharedPreferenceStorage.java
Outdated
Show resolved
Hide resolved
sacOO7
reviewed
Jul 7, 2021
sacOO7
reviewed
Jul 7, 2021
Member
|
@sacOO7 are you happy with the changes? |
sacOO7
approved these changes
Jul 20, 2021
QuintinWillison
suggested changes
Jul 27, 2021
Contributor
QuintinWillison
left a comment
QuintinWillison
left a comment
There was a problem hiding this comment.
Some tweaks, please.
QuintinWillison
approved these changes
Aug 3, 2021
QuintinWillison
deleted the
593-support-for-encryption-of-shared-preferences
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.