Skip to content

[AIT-295] Update Swift API references docs for protocol v5 changes#3171

Open
maratal wants to merge 4 commits intomainfrom
AIT-295-update-api-refs-for-swift
Open

[AIT-295] Update Swift API references docs for protocol v5 changes#3171
maratal wants to merge 4 commits intomainfrom
AIT-295-update-api-refs-for-swift

Conversation

@maratal
Copy link
Copy Markdown
Collaborator

@maratal maratal commented Feb 2, 2026

Description

Updates similar to #3134 re API reference. Examples were added in the previous PR.

Checklist

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 2, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: dc86b6cc-b1e0-42ae-ba6c-f208866ae29f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch AIT-295-update-api-refs-for-swift

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@maratal maratal added the review-app Create a Heroku review app label Feb 2, 2026
@ably-ci ably-ci had a problem deploying to ably-docs-ait-295-updat-evrrrp February 2, 2026 00:48 Failure
@ably-ci ably-ci had a problem deploying to ably-docs-ait-295-updat-evrrrp February 2, 2026 13:36 Failure
@maratal maratal force-pushed the AIT-295-update-api-refs-for-swift branch from ae4a1d7 to ce067c3 Compare February 3, 2026 22:46
@ably-ci ably-ci temporarily deployed to ably-docs-ait-295-updat-evrrrp February 3, 2026 22:46 Inactive
@maratal maratal force-pushed the AIT-295-update-api-refs-for-swift branch from ce067c3 to 3157bc2 Compare February 4, 2026 00:16
@ably-ci ably-ci temporarily deployed to ably-docs-ait-295-updat-evrrrp February 4, 2026 00:17 Inactive
@maratal maratal force-pushed the AIT-295-update-api-refs-for-swift branch from 3157bc2 to 599b0cb Compare February 4, 2026 00:29
@ably-ci ably-ci temporarily deployed to ably-docs-ait-295-updat-evrrrp February 4, 2026 00:29 Inactive
@maratal maratal force-pushed the AIT-295-update-api-refs-for-swift branch from 599b0cb to 3dbb659 Compare February 4, 2026 00:36
@ably-ci ably-ci temporarily deployed to ably-docs-ait-295-updat-evrrrp February 4, 2026 00:36 Inactive
@lawrence-forooghian
Copy link
Copy Markdown
Contributor

lawrence-forooghian commented Feb 27, 2026

Hey @maratal, sorry for taking a while to get back to you on this one. I wanted to get Claude to review this for me but there wasn't an authoritative source of information on the ably-cocoa Swift API for it to cross-reference against. Now there is: https://sdk.ably.com/builds/ably/ably-cocoa/main/markdown-api-reference/api.md. I got Claude to review it; in particular I wanted to know:

  • whether the references you've added are accurate (compared to the Markdown reference) — it said no, there are some inaccuracies
  • whether we should be using the ART prefixes (i.e. how do we do it elsewhere in these references) — it said we should be

— I don't have the time right now to check through its output and write it up as a review, so could I please ask that you get Claude to do this review for you and address the feedback?

maratal and others added 3 commits March 23, 2026 02:57
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…Result in Swift param tables

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…teDeleteResult in Swift blocks

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@maratal
Copy link
Copy Markdown
Collaborator Author

maratal commented Mar 23, 2026

FYI @lawrence-forooghian — while reviewing the Swift blocks in this PR, I noticed there are pre-existing usages of Swift types without the ART prefix in parameter description tables elsewhere in the docs (outside the scope of this PR).

Examples found in existing <If lang="objc,swift"> blocks in realtime-sdk/channels.mdx:

  • ErrorInfo without ART prefix (lines 1488, 1605) — should be ARTErrorInfo

These are in the channel state subscription methods (on/once/off), not touched by this PR. Worth a follow-up fix in a separate PR.

@lawrence-forooghian
Copy link
Copy Markdown
Contributor

Please could you squash the commits?

@maratal
Copy link
Copy Markdown
Collaborator Author

maratal commented Apr 1, 2026

Please could you squash the commits?

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-app Create a Heroku review app

Development

Successfully merging this pull request may close these issues.

3 participants