Merged
Conversation
owenpearson
requested review from
a team,
SimonWoolf,
lawrence-forooghian and
lmars
owenpearson
force-pushed
the
new-batch-specs
branch
from
f1ca8c0 to
2203f17
Compare
owenpearson
force-pushed
the
new-batch-specs
branch
from
2203f17 to
b903f90
Compare
Collaborator
lawrence-forooghian
left a comment
lawrence-forooghian
left a comment
There was a problem hiding this comment.
As well as the comments below, I also wanted to mention that we need to write documentation comments for these new APIs and open a PR into https://github.com/ably/sdk-api-reference. The process described by EdX DR 5.4 isn't quite clear about when this should happen, but I’d suggest that it would be best to do it alongside the spec PR (i.e. now), so that reviewers of the spec PR can also understand how the new functionality is meant to be used by users.
owenpearson
force-pushed
the
new-batch-specs
branch
from
b903f90 to
e3eb6fb
Compare
owenpearson
force-pushed
the
new-batch-specs
branch
from
e3eb6fb to
24e8317
Compare
SimonWoolf
approved these changes
May 2, 2023
Member
SimonWoolf
left a comment
SimonWoolf
left a comment
There was a problem hiding this comment.
Looks good, couple comments
owenpearson
force-pushed
the
new-batch-specs
branch
from
24e8317 to
08c4a9c
Compare
owenpearson
force-pushed
the
new-batch-specs
branch
from
08c4a9c to
b1c42d0
Compare
owenpearson
force-pushed
the
new-batch-specs
branch
from
b1c42d0 to
b511642
Compare
owenpearson
force-pushed
the
new-batch-specs
branch
from
b511642 to
cfa3e5d
Compare
owenpearson
force-pushed
the
new-batch-specs
branch
from
cfa3e5d to
9ee13a4
Compare
owenpearson
force-pushed
the
new-batch-specs
branch
from
9ee13a4 to
9762cc3
Compare
owenpearson
force-pushed
the
new-batch-specs
branch
from
9762cc3 to
2b8410c
Compare
lawrence-forooghian
approved these changes
May 17, 2023
Collaborator
lawrence-forooghian
left a comment
lawrence-forooghian
left a comment
There was a problem hiding this comment.
Looks good, one outstanding question about the messageId response property, but feel free to resolve and merge if you consider it a non-blocker.
lawrence-forooghian
force-pushed
the
new-batch-specs
branch
from
2b8410c to
38536ae
Compare
These were never implemented in any SDK so is safe to remove without deprectation
Co-authored-by: Lawrence Forooghian <lawrence@forooghian.com>
lawrence-forooghian
force-pushed
the
new-batch-specs
branch
from
38536ae to
9d38a1c
Compare
Co-authored-by: Lawrence Forooghian <lawrence@forooghian.com>
lawrence-forooghian
force-pushed
the
new-batch-specs
branch
from
9d38a1c to
97186e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #140
Doing this now so that we can publish this as spec v2.1 before working on spec v3
Adds new specs for batch REST methods, using the new batch response format via the
newBatchResponsequery param.For further information, see: