Make main skip link and nav links visible in dark mode.#519
Merged
Conversation
✅ Deploy Preview for accessiblecommunity ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
brian-montgomery
requested changes
Mar 26, 2026
brian-montgomery
left a comment
brian-montgomery
left a comment
Contributor
There was a problem hiding this comment.
It looks good, Alexis. Thank you for the check.
One thing, can you move the one bit of code over as noted below?
|
|
||
| .skip-link { | ||
| color: var(--bs-primary); | ||
| background-color: white; |
Contributor
There was a problem hiding this comment.
We already have a .skip-link specific section for dark mode here. Can you add the skip-link specific focus-visible and :not(:hover) stuff here instead ?
| } | ||
| } | ||
| @include color-mode(dark) { | ||
| #main-skip-link:focus-visible { |
Contributor
There was a problem hiding this comment.
Can you move this 5 lines into the .skip-link dark mode section in Header.astro ?
brian-montgomery
approved these changes
Apr 6, 2026
brian-montgomery
left a comment
brian-montgomery
left a comment
Contributor
There was a problem hiding this comment.
Thanks, Alexis!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #520