Create "Column" and "ThemedColumn" components and apply them across the website.#535
Merged
Conversation
….astro. Co-authored-by: brian-montgomery <brian-montgomery@users.noreply.github.com>
✅ Deploy Preview for accessiblecommunity ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
brian-montgomery
approved these changes
Apr 14, 2026
brian-montgomery
left a comment
brian-montgomery
left a comment
Contributor
There was a problem hiding this comment.
Thank you for finding and changing all of these, Alexis. I'm sure that took some time.
| } | ||
|
|
||
| .bg-example { | ||
| background-image: url(${fixBgNoColor.src}); |
Contributor
There was a problem hiding this comment.
Just a note: I don't think this fix will work (in this case), but it's okay, because this page isn't being used (and we should probably remove it).
| export interface Props { | ||
| id?: string; | ||
| class?: string; | ||
| noDefault?: boolean; |
Contributor
There was a problem hiding this comment.
I still don't love the noDefault name we came up with, but I still can't think of anything better.
Perhaps the right thing to do is to have it be two separate Components, one with the col (or an appropriately sized col) and one without? I don't know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #430 and applies the new "Column" and "ThemedColumn" components across the website. The "ThemedColumn" was mostly able to be used in place of where the "ThemedBox" was being used, but in some cases the "ThemedBox" was better suited.