Skip to content

Do you mean email#87

Merged
fstrr merged 8 commits into
mainfrom
do-you-mean-email
Apr 4, 2025
Merged

Do you mean email#87
fstrr merged 8 commits into
mainfrom
do-you-mean-email

Conversation

@fstrr

@fstrr fstrr commented Mar 24, 2025

Copy link
Copy Markdown
Collaborator

Adds a "did you mean [this email provider]" prompt in the volunteer sign up form. Updates list of issues.

@fstrr
fstrr requested a review from kfranqueiro March 24, 2025 19:34
@kfranqueiro

kfranqueiro commented Mar 27, 2025

Copy link
Copy Markdown
Collaborator

FYI I've fixed a couple of things on the branch (removed an added top-level package.json that isn't necessary, moved the added breaks to the Volunteer section, added breaks for WCAG 3).

I forget what exactly the real case this was inspired by did, but do you think this would be slightly more realistic/plausible if it waited until at least "@" or "@" followed by anything is present before complaining, rather than right away? (If so, I can make the adjustment)

@fstrr

fstrr commented Mar 27, 2025

Copy link
Copy Markdown
Collaborator Author

Thanks for fixing things. I've just gone back to the ecommerce form that does this thing and they actually pop that message up when the email address text field is moved out of. That would be a little better for this, I think.

@kfranqueiro

Copy link
Copy Markdown
Collaborator

I've just gone back to the ecommerce form that does this thing and they actually pop that message up when the email address text field is moved out of.

Can you test whether it happens any time it loses focus, regardless of how much or little is input? (i.e. if the user hasn't even gotten to the "@" part yet)

I do wonder how cases this specific fare in audits in general - i.e. it seems easy to miss

@kfranqueiro

Copy link
Copy Markdown
Collaborator

Update: during yesterday's meeting we decided to switch this to onblur, and determined that the inspiration for this example only triggers when the field contains "@". I've adjusted the logic accordingly.

@fstrr
fstrr merged commit c2fc702 into main Apr 4, 2025
@fstrr
fstrr deleted the do-you-mean-email branch April 4, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants