Validate template execution results#144
Open
Rishabh060105 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Rishabh Jain <rishabhj2005@email.com>
Author
|
Hi @mttrbrts , I reviewed the changes against the pointers provided in the original issue and updated the branch accordingly. What changed
Validation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix TemplateArchiveProcessor execution result validation
This PR adds the runtime validation requested in #135 so
TemplateArchiveProcessorfails fast when template logic returns malformed execution output.Changes
TemplateArchiveProcessor.trigger()before returning execution resultsTemplateArchiveProcessor.init()before returning execution resultstrigger()returns:resultas an objectstateas an objecteventsas an arrayinit()returns:stateas an objecttest/TemplateArchiveProcessor.test.tswith malformed output cases for:resultstateeventsFlags
trigger()returnsresult,state, andeventsTemplateArchiveProcessortest suite rather than mock-only testsScreenshots or Video
Related Issues
Author Checklist
--signoffoption of git commit.mainfromRishabh060105/validate-execution-resultValidation
node --experimental-vm-modules node_modules/jest-cli/bin/jest.js test/TemplateArchiveProcessor.test.ts --runInBand