Skip to content

Common - Add wheel hitpoint function#10075

Merged
johnb432 merged 2 commits intomasterfrom
common-wheel-selection-function
Jun 17, 2024
Merged

Common - Add wheel hitpoint function#10075
johnb432 merged 2 commits intomasterfrom
common-wheel-selection-function

Conversation

@johnb432
Copy link
Copy Markdown
Contributor

When merged this pull request will:

  • Moves getWheelHitPointsWithSelections from repair to common, so that both repair and grenades can use the same function.
  • getWheelHitPointsWithSelections now uses caching.
  • draw_showRepairInfo no longer stack drawing icons when the game is paused.

TODO in another PR: getWheelHitPointsWithSelections doesn't work with numerous Global Mobilisation vehicles. For some reason the selections aren't reported and I can't understand why.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/enhancement Release Notes: **IMPROVED:** label Jun 15, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Jun 15, 2024
Copy link
Copy Markdown
Member

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread addons/common/XEH_preStart.sqf Outdated
@johnb432 johnb432 merged commit 4210710 into master Jun 17, 2024
@johnb432 johnb432 deleted the common-wheel-selection-function branch June 17, 2024 17:31
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
* Add wheel hitpoint function

* Moved cache to missionNamespace
Vdauphin added a commit to Vdauphin/HeartsAndMinds that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Release Notes: **IMPROVED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants