Sitting - Add config overwrite for random animation pool#10120
Merged
PabstMirror merged 5 commits intoacemod:masterfrom Jul 18, 2024
Merged
Sitting - Add config overwrite for random animation pool#10120PabstMirror merged 5 commits intoacemod:masterfrom
PabstMirror merged 5 commits intoacemod:masterfrom
Conversation
Contributor
Author
|
The logic could probably be improved a little bit, not sure what exactly but it feels a bit off to me. |
DartRuffian
force-pushed
the
sitting/config-animations
branch
from
e10a071 to
f37abb4
Compare
johnb432
requested changes
Jul 17, 2024
Contributor
johnb432
left a comment
johnb432
left a comment
There was a problem hiding this comment.
You need to adapt the header for the new parameter, otherwise looks fine.
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Contributor
Author
Forgot about that, will fix that quickly |
johnb432
reviewed
Jul 17, 2024
Contributor
|
I imagine you want to update the call to the function too? Otherwise, why add this to a non-API function? |
Contributor
Author
|
Yeah I just had to leave for work so didn't have a chance to update that, could probably do it from my phone |
PabstMirror
approved these changes
Jul 18, 2024
blake8090
pushed a commit
to blake8090/ACE3
that referenced
this pull request
Aug 18, 2024
* Add config property animation overwrite * Update addons/sitting/functions/fnc_getRandomAnimation.sqf Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com> * Fix header * Update addons/sitting/functions/fnc_getRandomAnimation.sqf * Update function call --------- Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.