Skip to content

Dogtags - Rename inventory items via CBA#10130

Merged
PabstMirror merged 2 commits intomasterfrom
dogCBA
Jul 28, 2024
Merged

Dogtags - Rename inventory items via CBA#10130
PabstMirror merged 2 commits intomasterfrom
dogCBA

Conversation

@PabstMirror
Copy link
Copy Markdown
Contributor

@PabstMirror PabstMirror commented Jul 20, 2024

alt to #10102
soft-requires CBATeam/CBA_A3#1329

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jul 20, 2024
johnb432
johnb432 requested changes Jul 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall much more elegant than #10102, hopefully we can get that CBA function merged in 3.18.0.

Would we want to keep the if (isNil "CBA_fnc_renameInventoryItem") exitWith {}; line if it's merged into CBA?

Comment thread addons/dogtags/XEH_postInit.sqf Outdated
@PabstMirror @johnb432
Update addons/dogtags/XEH_postInit.sqf
019aef6 
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
@PabstMirror
Copy link
Copy Markdown
Contributor Author

PabstMirror commented Jul 21, 2024

I guess [] call nil is safe, so it doesn't need to be there,
I just think it makes it clear why the feature might not work if not running on a dev build of cba,
we can cleanup when cba3.18 is out

@PabstMirror PabstMirror added this to the 3.18.0 milestone Jul 21, 2024
@PabstMirror PabstMirror merged commit a6ab050 into master Jul 28, 2024
@PabstMirror PabstMirror deleted the dogCBA branch July 28, 2024 16:43
@johnb432 johnb432 mentioned this pull request Jul 28, 2024
Closed
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
@PabstMirror @johnb432 @blake8090
Dogtags - Rename inventory items via CBA (acemod#10130)
f9dfe3a 
* Dogtags - Rename inventory items via CBA

* Update addons/dogtags/XEH_postInit.sqf

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>

---------

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnb432 johnb432 johnb432 approved these changes

Assignees

No one assigned

Labels

kind/enhancement Release Notes: **IMPROVED:**

Projects

None yet

Milestone

3.18.0

Development

Successfully merging this pull request may close these issues.

2 participants

@PabstMirror @johnb432