Skip to content

Nightvision - Improve NVG Brightness adjustment limits#10136

Merged
LinkIsGrim merged 7 commits intoacemod:masterfrom
SpicyBagpipes:patch-2
Aug 2, 2024
Merged

Nightvision - Improve NVG Brightness adjustment limits#10136
LinkIsGrim merged 7 commits intoacemod:masterfrom
SpicyBagpipes:patch-2

Conversation

@SpicyBagpipes
Copy link
Copy Markdown
Contributor

When merged this pull request will:

  • Move hardcoded limits for nvg brightness adjustment to variables

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

Comment thread addons/nightvision/XEH_postInit.sqf Outdated
Copy link
Copy Markdown
Member

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation.

Comment thread addons/nightvision/XEH_postInit.sqf Outdated
Comment thread addons/nightvision/XEH_postInit.sqf Outdated
@SpicyBagpipes
Copy link
Copy Markdown
Contributor Author

Documentation.

9d761c9

@PabstMirror PabstMirror added this to the 3.18.0 milestone Jul 21, 2024
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jul 21, 2024
Copy link
Copy Markdown
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of const if the intention is easier changing than before?

@SpicyBagpipes
Copy link
Copy Markdown
Contributor Author

What is the point of const if the intention is easier changing than before?

Not meant to be changed mid-mission as is max/min

Comment thread addons/nightvision/XEH_postInit.sqf Outdated
@PabstMirror
Copy link
Copy Markdown
Contributor

a var that you can chang named const is a little bit funny but it's similar to what we did in #7236

Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@LinkIsGrim LinkIsGrim merged commit 90d855c into acemod:master Aug 2, 2024
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
* Update fnc_changeNVGBrightness.sqf

* Update XEH_postInit.sqf

* Update addons/nightvision/XEH_postInit.sqf

Co-authored-by: PabstMirror <pabstmirror@gmail.com>

* Update XEH_postInit.sqf

* Update fnc_changeNVGBrightness.sqf

* Update nightvision-framework.md

* load order independence

Co-authored-by: PabstMirror <pabstmirror@gmail.com>

---------

Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
@SpicyBagpipes SpicyBagpipes deleted the patch-2 branch March 5, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Release Notes: **IMPROVED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants