Aegis Compat - Overwrite some Aegis changes#10173
Merged
Conversation
PabstMirror
approved these changes
Aug 8, 2024
Contributor
|
We should put it in the patch notes so it's not a surprise to people
|
Contributor
Author
Would adding ACE3/addons/vehicles/config.cpp Lines 15 to 16 in b9a361f |
Contributor
Author
|
I haven't been able to make it create a dependency (I just placed down both variants of the Merkava in the editor - I'm not sure if you can do anything else). |
Contributor
|
We never had any luck getting I'd still like it in changelog for the mismatch errors people seem to always get but it's fine either way |
PabstMirror
approved these changes
Aug 10, 2024
blake8090
pushed a commit
to blake8090/ACE3
that referenced
this pull request
Aug 18, 2024
* Overwrite some Aegis changes * Preemptively overwrite upcoming changes to Aegis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
I've added the "ignore-changelog" tag because I don't want people thinking this is an official ACE-Aegis compat, as atm it's only doing fixes. Personally I'm not planning on adding any compatibility, but I decided to add it for future use.
In order to drop the word "compat", the only alternative would be to add this into the vehicles addon directly.
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.