Skip to content

Medical Feedback - Add parameters to fnc_playInjuredSound#10175

Merged
PabstMirror merged 3 commits intoacemod:masterfrom
tuntematonjr:master
Aug 9, 2024
Merged

Medical Feedback - Add parameters to fnc_playInjuredSound#10175
PabstMirror merged 3 commits intoacemod:masterfrom
tuntematonjr:master

Conversation

@tuntematonjr
Copy link
Copy Markdown
Contributor

When merged this pull request will:

  • Add parameters to allow changing distances for sounds for each severity.
  • Add parameter to allow unconscious units to do sounds.
  • This does not impact the default functionality.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

- added parameters to allow changing distances for sounds for each severity.
- added parameter to allow unconscious units to do sounds.
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Aug 8, 2024
@PabstMirror PabstMirror added this to the 3.18.0 milestone Aug 8, 2024
Copy link
Copy Markdown
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty to adjust the header to our current formatting style (header was outdated prior to this PR and given the opportunity, I figured I would address it now).

@PabstMirror PabstMirror merged commit b2a3fac into acemod:master Aug 9, 2024
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
* Additional parameters

- added parameters to allow changing distances for sounds for each severity.
- added parameter to allow unconscious units to do sounds.

* fix conditio

* Updated header formatting + minor tweaks

---------

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Release Notes: **IMPROVED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants