Explosives - Use triggerAmmo instead of setDamage#10182
Merged
Conversation
johnb432
commented
Aug 10, 2024
Member
Only if it's empty potentially? |
PabstMirror
approved these changes
Aug 12, 2024
Contributor
Author
APERS mine dispenser can't be empty, When it's triggered, it creates the submunitions and deletes the dispenser. |
LinkIsGrim
approved these changes
Aug 12, 2024
Contributor
Author
|
I'll make another PR for making the APERS mine dispenser trigger when destroyed, as to keep things separate. |
This was referenced Aug 12, 2024
blake8090
pushed a commit
to blake8090/ACE3
that referenced
this pull request
Aug 18, 2024
* Use `triggerAmmo` instead of `setDamage` * Update docs/wiki/framework/explosives-framework.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Do we want the APERS mine dispenser not to explode when destroyed?
TODO:
triggerAmmoneeds to be local) - needs to be localsetShotParents/getShotParentsstill works - tested with a dedicated server and everything works as expected.IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.