Frag - Spall simulation rewrite by lambdatiger · Pull Request #10247 · acemod/ACE3

lambdatiger · 2024-08-23T23:38:45Z

This PR is based on PR #10157 and requires it to be merged.

When merged this pull request will:

Leverages both projectile "HitPart" and "Penetrated" event handlers to avoid the changes in velocity, and therefore spall energy, being summed into the first "HitPart" event handler.
Switch spall production from individual projectile creation to submunition based creation.
Uses a method of approximating kinetic energy change based on velocity change and some rough coefficients to vary the amount of spall produced be different rounds.
- Provides a coefficient in addon option to increase or decrease the amount of spall energy for any impact.
Considers material projectile impacts when producing spall.
- Pre-caches material information for all BIS surface types, could be easily expanded to include all CDLC bisurfs.

Examples

40mm AP from a Badger IFV creating spalling within a room.

A 120mm HE round producing fragments (blue & green) outside a building, as well as spall (purple) within a room.

IMPORTANT

If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
Development Guidelines are read, understood and applied.
Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>

…haul

quick testing shows a whole 600ns increase in Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>

…shooters Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>

…haul

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>

…omment)

…haul

…omputations

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>

lambdatiger · 2024-09-18T22:25:19Z

Still working on the merge, will post when it's cleaned up

…frag-overhaul into spall-rework-v2

lambdatiger · 2024-09-18T23:30:19Z

~~Currently causes a CTD by way of buffer overflow after CBA's preinit message. I can't seem to nail down why and it doesn't produce a mdmp so I can't pass it off.~~

~~Edit: Wasn't able to figure this out at the moment. If someone would confirm it happens on their side as well I'd appreciate it.~~

lambdatiger · 2024-09-19T14:43:45Z

Waiting on fix for arma-rs

LinkIsGrim · 2024-09-20T06:27:53Z

+for "_i" from 2 to 21 do
+{
+    _spallPosASL = _lastSpallPos vectorAdd _deltaStep;
+    if (!lineIntersects [_lastSpallPos, _spallPosASL]) exitWith {


if then {break} seems more readable to me but that's just personal preference.

I think I switched to this because it is slightly faster, but I definitely can change that if there was a readability issue for you.

Was it an issue for you reading it?

Just haven't been reading much SQF lately. It's fine.

Oh, I could've made the change so a future person wouldn't struggle, but it's merged al;ready. I wasn't sure if that was an actual stumble or not.

johnb432

Otherwise lgtm

lambdatiger and others added 30 commits January 15, 2024 17:53

Comments fixed

6fc950a

slight performance increase using forEach loops

6e209ba

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>

Merge branch 'master' of https://github.com/lambdatiger/ace_frag-over…

d683be8

…haul

Small optimization to optimize config lookup

4ef1166

quick testing shows a whole 600ns increase in Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>

avoid mismatch sides when debugging frags with unconcious or captive …

902af64

…shooters Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>

removed return of sphere object, not required or useful.

bd33ab0

Merge branch 'master' of https://github.com/lambdatiger/ace_frag-over…

e3c8e8d

…haul

fixed a loop that got caught in the merge crossfire

f713791

Optimized approach to classifying blacklist type

a8e268c

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>

Implemented changes discussed here acemod#9728 (comment)

c4a93c7

Config lookup optimization mentioned by johnb432 here: acemod#9728 (c…

b2666fc

…omment)

white space/formatting changes

b780704

Merge branch 'master' of https://github.com/lambdatiger/ace_frag-over…

67e125c

…haul

removed old parameter changed in acemod@f28d5d2

85b566a

compacted text a bit

67ede76

formatting whitespace

572f909

Grammatical erros

7aa17aa

Changes as discussed here acemod#9728 (comment)

8dd76d1

Few quick optimizations of == to isEqualTo

6dacd38

Debug updated to be easier to control

9178611

Changed how spall hold off is calculated to avoid repeated unneeded c…

769bb29

…omputations

clarified a hold off variable

63cba6b

Better approach to ACE_FRAG_RM_EH macro

4be8c82

Git rid of superfulous stringtable entries

4727386

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>

unneeded parens

16e699e

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>

Clarified arguments

cdf1b4d

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>

getposATL to getPosATL

1b03ef7

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>

Update addons/frag/functions/fnc_dev_addRound.sqf

0958d6a

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>

Function header changes

1612872

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>

another great isNotEqualTo opportunity

3cc300a

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>

lambdatiger added 7 commits September 18, 2024 17:26

Merge branch 'master' into spall-rework-v2

86d3980

fixed a few more merge items

2ae4b24

Merge branch 'spall-rework-v2' of https://github.com/lambdatiger/ace_…

2ff1320

…frag-overhaul into spall-rework-v2

still solving some merge issues

bb452f7

more minor changes

c8ff2d7

missed stringtable cleanup

499bc45

missed prep entry

3c4d523

revert changes to match master

093a112

Merge branch 'acemod:master' into spall-rework-v2

b61d504

LinkIsGrim reviewed Sep 20, 2024

View reviewed changes

Comment thread addons/frag/XEH_preInit.sqf Outdated

LinkIsGrim reviewed Sep 20, 2024

View reviewed changes

Comment thread addons/frag/functions/fnc_doSpallHitPart.sqf Outdated

LinkIsGrim reviewed Sep 20, 2024

View reviewed changes

Comment thread addons/frag/functions/fnc_doSpallHitPart.sqf

LinkIsGrim reviewed Sep 20, 2024

View reviewed changes

Comment thread addons/frag/functions/fnc_doSpallHitPart.sqf Outdated

lambdatiger added 4 commits September 19, 2024 21:20

updated fragments to make the masses happy

b354243

EOF spaces

0c169d0

fixed missing params

50d8942

fixed hitPart params

9d6e418

LinkIsGrim reviewed Sep 20, 2024

View reviewed changes

PabstMirror approved these changes Sep 21, 2024

View reviewed changes

johnb432 reviewed Sep 21, 2024

View reviewed changes

lambdatiger added 4 commits September 21, 2024 16:20

clarifying unused iterator

83a3a0e

uinamespace the spall cache

cbbb1e5

fixed uiNamespace case

744a4c4

johnB's formatting pass

50beaf0

LinkIsGrim approved these changes Sep 21, 2024

View reviewed changes

LinkIsGrim merged commit c0b1a45 into acemod:master Sep 21, 2024

lambdatiger mentioned this pull request Sep 22, 2024

Frag - Implement Arma v2.18 changes from #10157 #10313

Merged

3 tasks

Conversation

lambdatiger commented Aug 23, 2024

Examples

IMPORTANT

Uh oh!

lambdatiger commented Sep 18, 2024

Uh oh!

lambdatiger commented Sep 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lambdatiger commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LinkIsGrim Sep 20, 2024

Choose a reason for hiding this comment

Uh oh!

lambdatiger Sep 20, 2024

Choose a reason for hiding this comment

Uh oh!

lambdatiger Sep 21, 2024

Choose a reason for hiding this comment

Uh oh!

LinkIsGrim Sep 21, 2024

Choose a reason for hiding this comment

Uh oh!

lambdatiger Sep 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnb432 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lambdatiger commented Sep 18, 2024 •

edited

Loading

lambdatiger commented Sep 19, 2024 •

edited

Loading

lambdatiger Sep 21, 2024 •

edited

Loading