Skip to content

Dragging - Fix dragging breaking via keybind#10261

Merged
LinkIsGrim merged 1 commit intomasterfrom
dragging-fix-dragging
Aug 27, 2024
Merged

Dragging - Fix dragging breaking via keybind#10261
LinkIsGrim merged 1 commit intomasterfrom
dragging-fix-dragging

Conversation

@johnb432
Copy link
Copy Markdown
Contributor

When merged this pull request will:

  • Previously, if you double tapped the dragging keybind, it would fail to release the claim on the dragged object. This PR fixes that.
  • Stopped setting variables unnecessarily. I'm a little afraid of race condition bs that could happen.
  • Use local _target variable, instead of getting QGVAR(draggedObject). Imo the updated version is safer, because QGVAR(draggedObject) could be changed for some reason.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/bug-fix Release Notes: **FIXED:** label Aug 25, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Aug 25, 2024
@LinkIsGrim LinkIsGrim merged commit 3b10396 into master Aug 27, 2024
@LinkIsGrim LinkIsGrim deleted the dragging-fix-dragging branch August 27, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug-fix Release Notes: **FIXED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants