Skip to content

CSW - Improve "disableWeaponAssembly" status effect usage#10273

Merged
johnb432 merged 1 commit intomasterfrom
csw-improve-disableweaponassembly
Aug 30, 2024
Merged

CSW - Improve "disableWeaponAssembly" status effect usage#10273
johnb432 merged 1 commit intomasterfrom
csw-improve-disableweaponassembly

Conversation

@johnb432
Copy link
Copy Markdown
Contributor

When merged this pull request will:

  • Turn off vanilla assembly for placed tripods and assembled CSWs, so that FUNC(initVehicle) can handle enabling/disabling vanilla assembly when the QGVAR(assemblyMode) is set on the vehicle.
  • Only set the status effect where the gunner's turret is local. Until now, every machine set a status effect that has a global effect, which is useless.
  • Removed the execNextFrame in FUNC(initVehicle), because it runs 1 second after a vehicle has been created, so no need for the frame of delay.
  • Optimised FUNC(staticWeaponInit_unloadExtraMags) slightly (from CSW - Rework settings #9901).

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/enhancement Release Notes: **IMPROVED:** label Aug 29, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Aug 29, 2024
@johnb432 johnb432 merged commit c80d623 into master Aug 30, 2024
@johnb432 johnb432 deleted the csw-improve-disableweaponassembly branch August 30, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Release Notes: **IMPROVED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants