General - Optimize some if statements#10302
Merged
LinkIsGrim merged 1 commit intomasterfrom Sep 11, 2024
Merged
Conversation
Member
|
Code is fine, but I think this is less readable. Worth it? |
Member
|
imo it is more readable, with maybe some exception, when it is as readable. The code is the same, it's still if else, it's just swapped order |
Contributor
|
Way more readable cuz it ain't backwards. |
johnb432
approved these changes
Sep 10, 2024
Contributor
johnb432
left a comment
johnb432
left a comment
There was a problem hiding this comment.
Code is fine, but I think this is less readable.
I feel the same way for most isNull/isNil checks, but it doesn't matter much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a tiny bit faster to remove the not
these are mostly in functions that may be called more frequently