Zeus - Add spectator module#6202
Merged
LinkIsGrim merged 10 commits intoacemod:masterfrom May 29, 2024
Merged
Conversation
Contributor
Unless you happen to speak any of the other languages, you don't need to add this taks to this PR :~) |
PabstMirror
reviewed
Mar 19, 2018
PabstMirror
reviewed
Mar 19, 2018
mharis001
commented
Mar 21, 2018
Dystopian
reviewed
Mar 21, 2018
Dystopian
reviewed
Mar 21, 2018
Dystopian
reviewed
Mar 21, 2018
Dystopian
reviewed
Mar 21, 2018
Dystopian
reviewed
Mar 21, 2018
Dystopian
reviewed
Mar 21, 2018
Dystopian
reviewed
Mar 21, 2018
dedmen
reviewed
Sep 18, 2018
dedmen
reviewed
Sep 18, 2018
dedmen
reviewed
Sep 18, 2018
dedmen
reviewed
Sep 18, 2018
dedmen
approved these changes
Sep 18, 2018
Contributor
dedmen
left a comment
dedmen
left a comment
There was a problem hiding this comment.
Besides my comments, nothing to object
kymckay
approved these changes
Apr 4, 2024
Member
kymckay
left a comment
kymckay
left a comment
There was a problem hiding this comment.
Nice 👍 Not sure why we didn't think of this years ago!
johnb432
approved these changes
Apr 10, 2024
Contributor
There was a problem hiding this comment.
Tested, LGTM.
Ability to remove players from spectating that have forced interface?
For players that are assigned a forced interface via the module, you can "unforce" it by using the module again. I didn't test it for players that are in spectator slots, but imo that can be disregarded.
LinkIsGrim
approved these changes
May 29, 2024
blake8090
pushed a commit
to blake8090/ACE3
that referenced
this pull request
Aug 18, 2024
Co-authored-by: Ozan Eğitmen <ozan@egitmen.net> Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
It would be useful to have to the ability to make people spectators for zeus created missions, where the framework isn't necessarily integrated into the mission fully.
TODO: