General - Change CBA Namespaces to HashMap#8801
Merged
LinkIsGrim merged 32 commits intoacemod:masterfrom Jun 11, 2024
Merged
Conversation
BrettMayson
changed the title
This was referenced Mar 27, 2024
Contributor
|
@LinkIsGrim Can you take a look at this? |
LinkIsGrim
commented
May 29, 2024
Member
Author
LinkIsGrim
left a comment
LinkIsGrim
left a comment
There was a problem hiding this comment.
Going through it. Should get around to replacing get + isNil with getOrDefaultCall eventually (HEMTT catch?), but separate PR for that.
PabstMirror
reviewed
May 29, 2024
Contributor
|
I am in favor of this |
johnb432
reviewed
Jun 5, 2024
LinkIsGrim
commented
Jun 11, 2024
LinkIsGrim
commented
Jun 11, 2024
LinkIsGrim
commented
Jun 11, 2024
LinkIsGrim
commented
Jun 11, 2024
Member
Author
LinkIsGrim
left a comment
LinkIsGrim
left a comment
There was a problem hiding this comment.
Should be good to go when comments are addressed
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
johnb432
approved these changes
Jun 11, 2024
Member
Author
|
what could go wrong |
blake8090
pushed a commit
to blake8090/ACE3
that referenced
this pull request
Aug 18, 2024
* medical_treatment * advanced_throwing * common, csw * Update fnc_replaceRegisteredItems.sqf * Sanitised numerous components * Update XEH_postInit.sqf * Update XEH_postInit.sqf * FUNC -> LINKFUNC * Changed tagging hashmap * Reverted some changes * Reverted some changes * Update XEH_clientInit.sqf * Tweaks and fixes * Fix number replacements * Minor cleanup * Update fnc_getMagazineName.sqf * Update fnc_getMagazineName.sqf * Minor improvement * Made factions case-sensitive and added `toLowerANSI` to be safe * Update fnc_getDetectedObject.sqf * Update addons/common/functions/fnc_actionKeysNamesConverted.sqf Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com> * Throw error if item doesn't exist --------- Co-authored-by: Salluci <69561145+Salluci@users.noreply.github.com> Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
countloops toforEachwhere appropriate.IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.