Medical Treatment - Add Grave Digging for Corpse Disposal

[Drofseh]

When merged this pull request will:

• Add the ability to dig a grave for a unit, requires an entrenching tool
• Create new funciton for both body bag and grave placement

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[BrettMayson]

Overall I think this needs a setting

fnc_placeInBodyBagOrGrave.sqf needs to be reworked

[LinkIsGrim]

Morbid.

[Drofseh]

fnc_placeInBodyBagOrGrave.sqf needs to be reworked

It is a little messy, but I didn't want to make a 2nd function that reused 99% of the same code as the body bag.
Any suggestions for improvement?

[BrettMayson]

Could also add an option to hide the body without the grave marker, could be useful for PvP

[Drofseh]

Could also add an option to hide the body without the grave marker, could be useful for PvP

I don't really want to make them disappear without cost.

With this PR if you don't have a body bag you can dig them a grave with your entrenching tool. I think it'll be good for longer format games, especially with a persistence system.

For hiding bodies quickly for PVP I think the corpse dragging that's being worked on is good to get them out of the way, but making them magically disappear is too much.

[BrettMayson]

I didn't say it should be without cost, still require an entrenching tool, and it can be another setting.

[commy2]

Cross? What if the guy was muslim/hindu/orthodox/jew/atheist?

[Drofseh]

Cross? What if the guy was muslim/hindu/orthodox/jew/atheist?

I don't disagree, but these are our options.

The only one without a cross is a grassy one from Contact, but the grass means it won't look good on a lot of terrain, likewise the two with stone or rocks on the left, so I picked the one that is entirely dirt.

[Drofseh]

I've overhauled the functions a little, can you let me know what you think @BrettMayson

[jonpas]

What about picking the one depending on surface?

[Drofseh]

What about picking the one depending on surface?

For the type of grave? I don't really think it's worth it, the dirt one should look fine of all surfaces. I just wish the grassy one on the right was dirt, or that it had texture selections.

[Drofseh]

I feel this is complete now.

[johnb432]

Review I made includes:

• Removing dependency on ace_trenches. If ace_trenches isn't loaded, you can't do the action.
• Expanded the action so that all third party entrenching tools can be used to bury bodies.
• Some comment formatting.

---

However, additions are still needed in XEH_PREP.hpp:

PREP(canDigGrave);
PREP(placeInBodyBagOrGrave);
PREP(placeInGrave);

Change in XEH_postInit.sqf required:
[QGVAR(placeInBodyBag), LINKFUNC(placeInBodyBag)] call CBA_fnc_addEventHandler;

->

[QGVAR(placeInBodyBagOrGrave), LINKFUNC(placeInBodyBagOrGrave)] call CBA_fnc_addEventHandler;

[PabstMirror]

Added ability to change grave type if mission maker really wants to
e.g. unmarked grave
ace_medical_treatment_graveClassname = "Land_Grave_11_F";

[johnb432]

Added ability to change grave type if mission maker really wants to e.g. unmarked grave ace_medical_treatment_graveClassname = "Land_Grave_11_F";

Needs documentation, but good idea!

[Drofseh]

Are we ok with this being the default? I feel like all missions will just have a bunch of graves now. 🤔

I could increase the default and max time to dig if you'd like. Currently 30 default, 120 max (twice that of using a body bag for both)

[johnb432]

Are we ok with this being the default? I feel like all missions will just have a bunch of graves now. 🤔

I could increase the default and max time to dig if you'd like. Currently 30 default, 120 max (twice that of using a body bag for both)

I think when ACE 3.16.0 is released missions might be flooded with graves, as its a novelty, but it will wear off over time imo. Personally I don't like to wait for interactions, so 30 s seems fine to be, but I can understand if others think it's too quick, although I would set the default to 60 s max.

[LinkIsGrim]

script_component includes need to be updated

Stale

[IceBreakr-SBP]

Any chance to dig up the body? Halloween is approaching ;)

[Drofseh]

Any chance to dig up the body? Halloween is approaching ;)

lol, sorry you'll have to script that one yourself