Skip to content

General - Events for Mods#9813

Merged
PabstMirror merged 11 commits intoacemod:masterfrom
BrettMayson:mod_events
Mar 4, 2024
Merged

General - Events for Mods#9813
PabstMirror merged 11 commits intoacemod:masterfrom
BrettMayson:mod_events

Conversation

@BrettMayson
Copy link
Copy Markdown
Member

@BrettMayson BrettMayson commented Mar 1, 2024

Work in progress, mainly for KAM

When merged this pull request will:

  • Add events for mods to integrate better with ACE internals, without overwriting functions
  • More internal medical variables

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

Comment thread addons/medical_gui/functions/fnc_updateCategories.sqf
@BrettMayson BrettMayson marked this pull request as ready for review March 3, 2024 00:55
@BrettMayson
Copy link
Copy Markdown
Member Author

Working fine with a version of KAM that requires it.

Comment thread addons/medical_treatment/functions/fnc_fullHealLocal.sqf Outdated
Copy link
Copy Markdown
Member

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

Documentation in events-framework page?

@LinkIsGrim LinkIsGrim added this to the 3.17.0 milestone Mar 3, 2024
@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Mar 3, 2024
@LinkIsGrim LinkIsGrim modified the milestones: 3.17.0, 3.17.1 Mar 3, 2024
@LinkIsGrim LinkIsGrim modified the milestones: 3.17.1, 3.17.0 Mar 3, 2024
Comment thread docs/wiki/framework/events-framework.md Outdated
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
Copy link
Copy Markdown
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@PabstMirror PabstMirror merged commit 67fa53f into acemod:master Mar 4, 2024
@BrettMayson BrettMayson deleted the mod_events branch March 4, 2024 21:22
MiszczuZPolski pushed a commit to KAT-Advanced-Medical/KAM that referenced this pull request Apr 1, 2024
**When merged this pull request will:**
- Chemical is now modular
- Surgery is now modular
- Pharma is now modular
- Create ACE events so that KAM doesn't need to overwrite some files

**Semi Related**
- Update to support ACE's new maxDoseDeviation

Requires:
- acemod/ACE3#9813
- acemod/ACE3#9816

Moved from KAM to ACE:
- acemod/ACE3#9817
- acemod/ACE3#9815

Currently removed, needs to be added to ACE:
- Show inactive status setting for medical_gui

### IMPORTANT

- [Development Guidelines](https://ace3.acemod.org/wiki/development/)
are read, understood and applied.
- Title of this PR uses our standard template `Component -
Add|Fix|Improve|Change|Make|Remove {changes}`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Release Notes: **IMPROVED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants