Artillery - Add Rangetable Keybind, Fix remembering last charge#9818
Merged
LinkIsGrim merged 3 commits intoacemod:masterfrom Mar 3, 2024
Merged
Artillery - Add Rangetable Keybind, Fix remembering last charge#9818LinkIsGrim merged 3 commits intoacemod:masterfrom
LinkIsGrim merged 3 commits intoacemod:masterfrom
Conversation
Finished partial implementation of the last selected charge being remembered after closing the artillery table.
Member
|
Any side-effects from changing magazine type? |
Contributor
Author
|
Not that I can tell, everything appears to function normally, but I'll do some more testing. |
Contributor
Author
|
Nope, everything works normally, from assembly to ammo handling, loading/unloading and firing. |
LinkIsGrim
approved these changes
Mar 3, 2024
Member
LinkIsGrim
left a comment
There was a problem hiding this comment.
Tested, LGTM. Further improvements should be done in another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Further improvements for the future:
rangeTableOpencode;CfgMagazinesattributes needs to be overridden for that though;