Skip to content

Artillery - Add Rangetable Keybind, Fix remembering last charge#9818

Merged
LinkIsGrim merged 3 commits intoacemod:masterfrom
bagigi-arma:fix/artillery-improvements
Mar 3, 2024
Merged

Artillery - Add Rangetable Keybind, Fix remembering last charge#9818
LinkIsGrim merged 3 commits intoacemod:masterfrom
bagigi-arma:fix/artillery-improvements

Conversation

@mrschick
Copy link
Copy Markdown
Contributor

@mrschick mrschick commented Mar 2, 2024

When merged this pull request will:

  • Make 82mm Mortar Ammo visible in the Arsenal and Zeus inventory Editor, allowing individual rounds to be added and removed from inventories without throwing errors (at least with ZEN);
  • Add a keybind to open the 82mm Artillery Rangetable directly;
  • Fix the last selected charge not being remembered when reopening an artillery rangetable (not just 82mm), it appears this feature was incompletely implemented in the past;

Further improvements for the future:

  • Add keybind to open Artillery Rangetable on the closest vehicle, though that would require delving deeper into and probably duplicating some rangeTableOpen code;
  • Also allow adding 82mm Rounds into inventories from 3DEN's object inventory selector, no clue which CfgMagazines attributes needs to be overridden for that though;

mrschick added 3 commits March 2, 2024 16:37
Finished partial implementation of the last selected charge being remembered after closing the artillery table.
@LinkIsGrim
Copy link
Copy Markdown
Member

Any side-effects from changing magazine type?

@mrschick
Copy link
Copy Markdown
Contributor Author

mrschick commented Mar 2, 2024

Not that I can tell, everything appears to function normally, but I'll do some more testing.

@mrschick
Copy link
Copy Markdown
Contributor Author

mrschick commented Mar 2, 2024

Nope, everything works normally, from assembly to ammo handling, loading/unloading and firing.

@LinkIsGrim LinkIsGrim added kind/enhancement Release Notes: **IMPROVED:** kind/bug-fix Release Notes: **FIXED:** labels Mar 3, 2024
@LinkIsGrim LinkIsGrim added this to the 3.17.0 milestone Mar 3, 2024
Copy link
Copy Markdown
Member

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM. Further improvements should be done in another PR.

@LinkIsGrim LinkIsGrim changed the title Artillery - Add Rangetable Keybind and Fix Last Selected Charge not being remembered Artillery - Add Rangetable Keybind, Fix remembering last charge Mar 3, 2024
@LinkIsGrim LinkIsGrim merged commit 22deb3a into acemod:master Mar 3, 2024
@mrschick mrschick deleted the fix/artillery-improvements branch March 3, 2024 23:27
@PabstMirror PabstMirror removed the kind/bug-fix Release Notes: **FIXED:** label Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Release Notes: **IMPROVED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants