Skip to content

Refuel - Add ownership concept to nozzles & jerry cans#9826

Merged
johnb432 merged 1 commit intomasterfrom
refuel-nozzle-ownership-fix
Mar 5, 2024
Merged

Refuel - Add ownership concept to nozzles & jerry cans#9826
johnb432 merged 1 commit intomasterfrom
refuel-nozzle-ownership-fix

Conversation

@johnb432
Copy link
Copy Markdown
Contributor

@johnb432 johnb432 commented Mar 4, 2024

When merged this pull request will:

  • Fixes Logistics - Fuel canisters can be taken from someone carrying it #9753.
  • Minor optimisation.
  • You can still check the amount of fuel left in a jerry can when someone is carrying it. I left it in because I felt it was ok to leave in.
  • Race condition for claiming the object can most likely occur, but I'm not willing to rewrite the component with ace_common_fnc_claimSafeServer now.
  • I'm not sure which interaction expections should be checked for, but in my testing it worked. I was testing the virtual world with vehicles, did not test anything related to swimming, being on ladder, inside vehicles etc - I only tested the basic and most used use cases.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 merged commit 78334e2 into master Mar 5, 2024
@johnb432 johnb432 deleted the refuel-nozzle-ownership-fix branch March 5, 2024 19:56
@johnb432 johnb432 added the kind/bug-fix Release Notes: **FIXED:** label Mar 5, 2024
@johnb432 johnb432 added this to the 3.17.0 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug-fix Release Notes: **FIXED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logistics - Fuel canisters can be taken from someone carrying it

3 participants