Skip to content

General - Don't add keybinds to headless client/dedicated server#9842

Merged
johnb432 merged 3 commits intoacemod:masterfrom
prisonerMO:ace_keybinds
Mar 12, 2024
Merged

General - Don't add keybinds to headless client/dedicated server#9842
johnb432 merged 3 commits intoacemod:masterfrom
prisonerMO:ace_keybinds

Conversation

@prisonerMO
Copy link
Copy Markdown
Contributor

When merged this pull request will:

  • removes register keybinds on machines that don't have interfaces.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

Comment thread addons/rangecard/XEH_postInit.sqf Outdated
@LinkIsGrim LinkIsGrim changed the title Ace keybinds General - Don't add keybinds to headless client/dedicated server Mar 9, 2024
@LinkIsGrim LinkIsGrim added the kind/change Release Notes: **CHANGED:** label Mar 9, 2024
@prisonerMO prisonerMO requested a review from LinkIsGrim March 9, 2024 17:22
@mharis001
Copy link
Copy Markdown
Member

Is this needed?

https://github.com/CBATeam/CBA_A3/blob/master/addons/keybinding/fnc_addKeybind.sqf#L84

Copy link
Copy Markdown
Member

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not particularly needed, but doesn't hurt.

@LinkIsGrim LinkIsGrim added this to the 3.17.0 milestone Mar 10, 2024
@johnb432 johnb432 merged commit 5e1771a into acemod:master Mar 12, 2024
@prisonerMO prisonerMO deleted the ace_keybinds branch March 13, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/change Release Notes: **CHANGED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants