CSW - Improved weapon attachments handling

[johnb432]

When merged this pull request will:

• Title.
• Weapon accessories are returned to the player immediately.
• Magazines are checked if the are compatible with the CSW. If they are, they are added to the CSW, if they are not, the magazines are placed on the ground.

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[TheCandianVendingMachine]

I am not a fan of this. The progress bar continuing when you dont have the weapon is kinda bad UX, it should just fail when the item is removed. Likewise, the initial decision was to “simulate” the weapon being setup. This seems like change just for changes sake

[johnb432]

I am not a fan of this. The progress bar continuing when you dont have the weapon is kinda bad UX, it should just fail when the item is removed.

Yea, I can add that.

This seems like change just for changes sake

It's not intended to be. I find it unnecessary to remove a weapon, only to have to add it back again if you cancel. It means we also have to handle all attachments, which we currently don't do.

[TheCandianVendingMachine]

Wouldn’t the attachments would be killed when the weapon is removed and placed as a vehicle anyway? Logic needs to exist anyway for that edge case.

[johnb432]

Wouldn’t the attachments would be killed when the weapon is removed and placed as a vehicle anyway? Logic needs to exist anyway for that edge case.

Currently yes, I still need to add handling of attachments.

---

Imo it's just easier to remove upon success, but I can revert the behaviour.

[TheCandianVendingMachine]

I’d like another person to comment on it, I am not so against this I will just block it but I just see it as unnecessary

[johnb432]

@TheCandianVendingMachine I've removed the part where it only removes the weapon upon successful completion.
Essentially, this has become a different PR focussing on the improved handling of weapon attachments.

[LinkIsGrim]

@TheCandianVendingMachine any further thoughts? LGTM