Merged
Conversation
Mike-MF
reviewed
Apr 2, 2024
Member
There was a problem hiding this comment.
I'm probably the worst person to review this, I have no idea what CSW is or how it works.
Although I now realise this should probably depend on Vehicles as the Edit: Nevermind, they are in weapons, the file structure is just baffling.ace_csw_mortarBaseplate entries do come from there.
TheCandianVendingMachine
requested changes
Apr 2, 2024
johnb432
commented
Apr 2, 2024
TheCandianVendingMachine
approved these changes
Apr 2, 2024
Contributor
TheCandianVendingMachine
left a comment
TheCandianVendingMachine
left a comment
There was a problem hiding this comment.
as long as the weapons are real static weapons, this lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
I didn't try if it worked if you have CUP Units and/or Vehicles loaded, as I made this fix independently from that.
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.