Hearing - Improve and cleanup code#9933
Merged
LinkIsGrim merged 15 commits intomasterfrom May 24, 2024
Merged
Conversation
johnb432
commented
Apr 7, 2024
rautamiekka
suggested changes
Apr 7, 2024
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
LinkIsGrim
reviewed
Apr 7, 2024
PabstMirror
reviewed
Apr 11, 2024
PabstMirror
reviewed
Apr 11, 2024
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
johnb432
changed the title
johnb432
changed the title
LinkIsGrim
reviewed
May 23, 2024
LinkIsGrim
approved these changes
May 24, 2024
blake8090
pushed a commit
to blake8090/ACE3
that referenced
this pull request
Aug 18, 2024
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com> Co-authored-by: PabstMirror <pabstmirror@gmail.com> Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
ace_gunbag_fnc_isMachineGunto detect if a weapon is a machine gun.initSpeedrelies on the magazine and ammo can't change during play time for a magazineI've tested it, but I want someone who uses ACE hearing to also test it, as I don't usually enable ACE hearing.
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.