Skip to content

Fix parsing AcquireJob MessageQueueTokenExpiredError#2837

Merged
nikola-jokic merged 2 commits intomasterfrom
nikola-jokic/fix-acquire-job-token-expired-parsing
Aug 25, 2023
Merged

Fix parsing AcquireJob MessageQueueTokenExpiredError#2837
nikola-jokic merged 2 commits intomasterfrom
nikola-jokic/fix-acquire-job-token-expired-parsing

Conversation

@nikola-jokic
Copy link
Copy Markdown
Collaborator

No description provided.

@nikola-jokic nikola-jokic requested review from a team, mumoshu and toast-gear as code owners August 25, 2023 15:01
@nikola-jokic nikola-jokic added this to the gha-runner-scale-set-0.5.1 milestone Aug 25, 2023
Comment thread github/actions/client.go

if resp.StatusCode != http.StatusOK {
return nil, ParseActionsErrorFromResponse(resp)
if resp.StatusCode != http.StatusUnauthorized {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have test for these clients? 😄

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added one ☺️

@nikola-jokic nikola-jokic merged commit 52fc819 into master Aug 25, 2023
@nikola-jokic nikola-jokic deleted the nikola-jokic/fix-acquire-job-token-expired-parsing branch August 25, 2023 18:35
@Link- Link- modified the milestones: gha-runner-scale-set-0.5.1, gha-runner-scale-set-0.6.0 Sep 7, 2023
@Link- Link- added the gha-runner-scale-set Related to the gha-runner-scale-set mode label Sep 7, 2023
@nikola-jokic nikola-jokic restored the nikola-jokic/fix-acquire-job-token-expired-parsing branch September 26, 2023 09:51
@nikola-jokic nikola-jokic deleted the nikola-jokic/fix-acquire-job-token-expired-parsing branch September 26, 2023 09:57
unpollito pushed a commit to DistruApp/actions-runner-controller that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gha-runner-scale-set Related to the gha-runner-scale-set mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants