Merged
Conversation
bdehamer
commented
Apr 23, 2024
Comment on lines
-129
to
+128
| mediaType: BUNDLE_V02_MEDIA_TYPE, | ||
| mediaType: attestation.bundle.mediaType, |
Collaborator
Author
There was a problem hiding this comment.
When communicating the media type to the OCI registry, use the value from the attestation itself instead of hard-coding to a specific value.
bdehamer
commented
Apr 23, 2024
Comment on lines
-66
to
+76
| nock('https://api.github.com') | ||
| .post(/^\/repos\/.*\/.*\/attestations$/) | ||
| mockAgent | ||
| .get('https://api.github.com') | ||
| .intercept({ | ||
| path: /^\/repos\/.*\/.*\/attestations$/, | ||
| method: 'post' | ||
| }) |
Collaborator
Author
There was a problem hiding this comment.
In @actions/attest v1.2.1 there were changes to the way we interact with the GH API which require that we use a different strategy for mocking this interaction.
bdehamer
force-pushed
the
bdehamer/update-attest
branch
2 times, most recently
from
aa01c40 to
6caa493
Compare
Signed-off-by: Brian DeHamer <bdehamer@github.com>
bdehamer
force-pushed
the
bdehamer/update-attest
branch
from
6caa493 to
78f77ea
Compare
ejahnGithub
approved these changes
Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
@actions/attestlibrary from version 1.1.0 to 1.2.0. Importantly, this will result in attestations which use the new v0.3 Sigstore bundle media type.