Skip to content

Include step context name and start/finish time in step telemetry #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TingluoHuang merged 2 commits into from
Aug 23, 2022
+12 −0
Merged

Include step context name and start/finish time in step telemetry #2069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a7d345
Include step context name in telemetry.
TingluoHuang Aug 19, 2022
6b91532
.
TingluoHuang Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Runner.Worker/ExecutionContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,7 @@ public IExecutionContext CreateChild(
child.StepTelemetry.StepId = recordId;
child.StepTelemetry.Stage = stage.ToString();
child.StepTelemetry.IsEmbedded = isEmbedded;
child.StepTelemetry.StepContextName = child.GetFullyQualifiedContextName(); ;

return child;
}
Expand Down Expand Up @@ -959,6 +960,8 @@ public void PublishStepTelemetry()
_record.StartTime != null)
{
StepTelemetry.ExecutionTimeInSeconds = (int)Math.Ceiling((_record.FinishTime - _record.StartTime)?.TotalSeconds ?? 0);
StepTelemetry.StartTime = _record.StartTime;
StepTelemetry.FinishTime = _record.FinishTime;
}

if (!IsEmbedded &&
Expand Down
9 changes: 9 additions & 0 deletions src/Sdk/DTWebApi/WebApi/ActionsStepTelemetry.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ public ActionsStepTelemetry()
[DataMember(EmitDefaultValue = false)]
public Guid StepId { get; set; }

[DataMember(EmitDefaultValue = false)]
public string StepContextName { get; set; }

[DataMember(EmitDefaultValue = false)]
public bool? HasRunsStep { get; set; }

Expand Down Expand Up @@ -57,6 +60,12 @@ public ActionsStepTelemetry()
[DataMember(EmitDefaultValue = false)]
public int? ExecutionTimeInSeconds { get; set; }

[DataMember(EmitDefaultValue = false)]
public DateTime? StartTime { get; set; }

[DataMember(EmitDefaultValue = false)]
public DateTime? FinishTime { get; set; }

[DataMember(EmitDefaultValue = false)]
public string ContainerHookData { get; set; }
}
Expand Down