Fix template injection (zizmor alert #119) in e2e-versions.yml#1116
Closed
brunoborges with Copilot wants to merge 2 commits into
Closed
Fix template injection (zizmor alert #119) in e2e-versions.yml#1116brunoborges with Copilot wants to merge 2 commits into
brunoborges with Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix code scanning alert #119
Fix template injection (zizmor alert #119) in e2e-versions.yml
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a
zizmor/template-injectioncode scanning alert:${{ steps.setup-java-21.outputs.path }}and${{ steps.setup-java-21.outputs.version }}were interpolated directly inside arun:shell block, allowing step outputs containing shell metacharacters to inject arbitrary commands.Fix: Move template expressions out of the script body and into the step's
env:section, then reference them as plain shell variables — the same pattern used by the adjacent step (alert #118 fix).Related issue:
N/A
Check list:
npm run checklocally (format, lint, build, test) and all checks pass.