Skip to content

Add additionalPlugins parameter to getOctokit method #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luketomlinson merged 2 commits into from
Sep 22, 2022
+5 −3
Merged

Add additionalPlugins parameter to getOctokit method #1181

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb5fdef
Add additionalPlugins parameter to getOctokit method
luketomlinson Jun 27, 2022
101ce71
Simplify getOctokit
luketomlinson Sep 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/github/src/github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as Context from './context'
import {GitHub, getOctokitOptions} from './utils'

// octokit + plugins
import {OctokitOptions} from '@octokit/core/dist-types/types'
import {OctokitOptions, OctokitPlugin} from '@octokit/core/dist-types/types'

export const context = new Context.Context()

Expand All @@ -14,7 +14,12 @@ export const context = new Context.Context()
*/
export function getOctokit(
token: string,
options?: OctokitOptions
options?: OctokitOptions,
...additionalPlugins: OctokitPlugin[]
Comment thread
luketomlinson marked this conversation as resolved.
): InstanceType<typeof GitHub> {
if (additionalPlugins.length) {
Comment thread
luketomlinson marked this conversation as resolved.
Outdated
Comment thread
luketomlinson marked this conversation as resolved.
Outdated
const GitHubWithPlugins = GitHub.plugin(...additionalPlugins)
return new GitHubWithPlugins(getOctokitOptions(token, options))
}
return new GitHub(getOctokitOptions(token, options))
}